Re: PING: [RFA] Runtime Dwarf2 CFI engine cleanup

Daniel Jacobowitz
2003-02-27T14:17:19Z

On Thu, Feb 27, 2003 at 11:15:01AM +0100, Michal Ludvig wrote:
> Index: Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/gdb/Makefile.in,v
> retrieving revision 1.257.2.5
> diff -u -p -r1.257.2.5 Makefile.in
> --- Makefile.in 25 Nov 2002 22:05:38 -0000 1.257.2.5
> +++ Makefile.in 27 Feb 2003 10:01:03 -0000
> @@ -414,6 +414,12 @@ ANNOTATE_OBS = annotate.o
> @target_makefile_frag@
> # End of host and target-dependent makefile fragments
>
> +# Make a list of linked files depending on target's defines.
> +ifeq ($(USED_DWARF2CFI), 1)
> + TDEPFILES+=dwarf2cfi.o
> + CFLAGS+=-DUSED_DWARF2CFI
> +endif
> +

Nope. First of all, the mh files are on their way out; second of all,
you can't use ifeq in a Makefile, because that's a GNU make-ism.

I'd leave this alone until you can get someone to approve the previous
version, probably using the observer mechanism that Andrew and Joel are
designing.

--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer