Re: [rfa] HAVE_UINTPTR_T

[Daniel Jacobowitz <drow@mvista.com>]

On Tue, Feb 25, 2003 at 07:26:39PM -0600, Michael Elizabeth Chastain wrote:
> Draft #2.  I changed the variable to HAVE_UINTPTR_T, and I changed
> AC_TRY_RUN to AC_TRY_COMPILE.  I re-tested with and without
> uintptr_t in /usr/include/stdint.h to hit both paths.
> 
> I don't show diffs for regenerated 'configure'.  I regenerated
> 'configure' with stock autoconf 2.13 from ftp.gnu.org.
> 
> Again, this is so that the gdb build can do something better when
> it needs uintptr_t and doesn't have it (pr gdb/660).  My notion of
> 'something better' is going to be to spit out a better error message,
> not to actually work.  Somebody has to have a really old libc
> (more than 3 years old) to get this message, but with millions of
> users, some people do.
> 
> OK to commit?

More autoconf nits:


> +dnl See if C library supports "uintptr_t" type.
> +dnl AC_CHECK_TYPE is not enough because this type lives in a header file.
> +
> +AC_MSG_CHECKING(for uintptr_t in C library)
> +AC_CACHE_VAL(gdb_cv_have_uintptr_t,

Use AC_CACHE_CHECK.

> +[AC_TRY_COMPILE([#include <stdint.h>],
> +		[uintptr_t foo = 0;
> +	         return foo;],
> +                gdb_cv_have_uintptr_t=yes,
> +                gdb_cv_have_uintptr_t=no)])
> +AC_MSG_RESULT($gdb_cv_have_uintptr_t)
> +if test $gdb_cv_have_uintptr_t = yes; then
> +  AC_DEFINE(HAVE_UINTPTR_T)

You should probably use the multi-argument form of AC_DEFINE.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer