From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21876 invoked by alias); 25 Feb 2003 13:53:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21869 invoked from network); 25 Feb 2003 13:53:05 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 172.16.49.205 with SMTP; 25 Feb 2003 13:53:05 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18nhPI-0007TV-00; Tue, 25 Feb 2003 09:54:12 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18nfW2-00021S-00; Tue, 25 Feb 2003 08:53:02 -0500 Date: Tue, 25 Feb 2003 13:53:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Cc: Jorn Rennecke , Elena Zannoni Subject: Re: Unreviewed PATCH: SH Simulator - MAC.L implementation and MAC.W correction Message-ID: <20030225135302.GA7649@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com, Jorn Rennecke , Elena Zannoni References: <69595093233BB547BB70CF5E492B63F2DA69F7@sohm.kpit.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <69595093233BB547BB70CF5E492B63F2DA69F7@sohm.kpit.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-02/txt/msg00633.txt.bz2 On Tue, Feb 25, 2003 at 05:32:22PM +0530, Shrinivas Atre wrote: > Hi, > > Could someone please review the following patch for the SH-simulator? > > http://sources.redhat.com/ml/gdb/2002-11/msg00365.html Shrinivas, The patch looks good to me; I'm not all that fond of the xor games for the sign bit but the SH simulator already uses that construct so it's OK. However, I'm not very familiar with SH, I don't know the algorithm in question, and the SH sim doesn't have a specific maintainer. Elena, you're GDB's SH maintainer; do you have any comments on this patch? Or J"orn? -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer