From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-22698-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 4503 invoked by alias); 23 Feb 2003 20:07:48 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 4495 invoked from network); 23 Feb 2003 20:07:46 -0000
Received: from unknown (HELO duracef.shout.net) (204.253.184.12)
  by 172.16.49.205 with SMTP; 23 Feb 2003 20:07:46 -0000
Received: (from mec@localhost)
	by duracef.shout.net (8.11.6/8.11.6) id h1NK7jA00488;
	Sun, 23 Feb 2003 14:07:45 -0600
Date: Sun, 23 Feb 2003 20:07:00 -0000
From: Michael Elizabeth Chastain <mec@shout.net>
Message-Id: <200302232007.h1NK7jA00488@duracef.shout.net>
To: drow@mvista.com, gdb-patches@sources.redhat.com
Subject: Re: RFA: Fix tracepoints for LOC_COMPUTED - sort of
Cc: jimb@redhat.com
X-SW-Source: 2003-02/txt/msg00556.txt.bz2

I tested this with native i686-pc-linux-gnu, gcc v2 and v3,
dwarf-2 and stabs+.  It works for me.  It fixes this problem:

  FAIL: gdb.trace/packetlen.exp: setup collect actions

... with no regressions.

Lightly proofread, nothing wrong that I can see.

Recommended for approval.

Michael C

===

2003-02-23  Daniel Jacobowitz  <drow@mvista.com>

	* Makefile.in (dwarf2loc.o): Update dependencies.
	* ax-gdb.c (gen_var_ref): Handle LOC_COMPUTED and LOC_COMPUTED_ARG.
	* dwarf2expr.c (read_uleb128, read_sleb128): Make non-static.
	* dwarf2expr.h (read_uleb128, read_sleb128): Add prototypes.
	* dwarf2loc.c: Include "ax.h" and "ax-gdb.h".
	(locexpr_tracepoint_var_ref): New function.
	(dwarf2_locexpr_funcs): Add locexpr_tracepoint_var_ref.