From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21027 invoked by alias); 21 Feb 2003 14:10:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21012 invoked from network); 21 Feb 2003 14:10:29 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 172.16.49.205 with SMTP; 21 Feb 2003 14:10:29 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18mFkx-0003Nt-00 for ; Fri, 21 Feb 2003 10:10:35 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18mDrh-0008CW-00 for ; Fri, 21 Feb 2003 09:09:25 -0500 Date: Fri, 21 Feb 2003 14:10:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: RFA/symtab: Let search_symbols find exact matches Message-ID: <20030221140925.GA31205@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20030210160107.GA587@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.1i X-SW-Source: 2003-02/txt/msg00515.txt.bz2 On Thu, Feb 20, 2003 at 02:41:18PM -0800, David Carlton wrote: > On Mon, 10 Feb 2003 11:01:07 -0500, Daniel Jacobowitz said: > > > This patch renames search_symbols to search_symbols_aux, and lets it take an > > argument that specified regex or exact (well, strcmp_iw) matching. Then > > search_symbols becomes a wrapper. > > > The new function is used by make_symbol_overload_list, which shaves 50% time > > off of some tests in the C++ directory if your system libc has debugging > > symbols; it removes the bogusity where all psymtabs were converted to > > symtabs during overload resolution. Whew. This cuts memory for > > namespace.exp from 70MB to 7MB, allowing some of my hardware to actually run > > the test without crashing. > > Here's take two on my comments on this. First, I should say that I > totally agree that the aforementioned bogusity in > make_symbol_overload_list should go; as discussed in > , > though, there are ways of doing that that involve much less drastic > changes. Good enough for me. This patch is withdrawn. David, are you convinced that lookup_partial_symbol is close enough to what we want for the patch above? You expressed some concerns earlier. If you're happy with it, I'll approve the patch. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer