From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 752 invoked by alias); 15 Feb 2003 16:09:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 743 invoked from network); 15 Feb 2003 16:09:05 -0000 Received: from unknown (HELO duracef.shout.net) (204.253.184.12) by 172.16.49.205 with SMTP; 15 Feb 2003 16:09:05 -0000 Received: (from mec@localhost) by duracef.shout.net (8.11.6/8.11.6) id h1FG93q07582; Sat, 15 Feb 2003 10:09:03 -0600 Date: Sat, 15 Feb 2003 16:09:00 -0000 From: Michael Elizabeth Chastain Message-Id: <200302151609.h1FG93q07582@duracef.shout.net> To: gdb-patches@sources.redhat.com, kettenis@chello.nl Subject: Re: [RFA] Testsuite: fix attach.exp test for FreeBSD 5.0 X-SW-Source: 2003-02/txt/msg00342.txt.bz2 It looks good to me. I have two issues: . add '2003' to the copyright years. . please say what system(s) you tested it on. I proofread it and ran it through my test bed with no problems (native i686-pc-linux-gnu, red hat 8.0, glibc 2.2.93-5, gcc v2 and v3, dwarf-2 and stabs+). After those two issues, I would recommend this patch for approval (I can only recommend, I can't approve). Michael C Index: ChangeLog from Mark Kettenis * gdb.base/attach.exp: When trying to attach to a nonexistent process, make it possible to specify the PID based on the target.