From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10844 invoked by alias); 31 Jan 2003 19:26:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10825 invoked from network); 31 Jan 2003 19:26:30 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 172.16.49.205 with SMTP; 31 Jan 2003 19:26:30 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18eih1-00056L-00 for ; Fri, 31 Jan 2003 15:27:23 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18egod-0002in-00 for ; Fri, 31 Jan 2003 14:27:07 -0500 Date: Fri, 31 Jan 2003 19:26:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [RFA] Relocate debug information in object files (e.g. add-symbol-file) [take 2] Message-ID: <20030131192707.GA23658@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20020404170610.A3717@nevyn.them.org> <20021011144448.GA31467@nevyn.them.org> <15929.47017.286393.193280@localhost.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15929.47017.286393.193280@localhost.redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-01/txt/msg00842.txt.bz2 On Thu, Jan 30, 2003 at 06:39:21PM -0500, Elena Zannoni wrote: > Daniel Jacobowitz writes: > > Hey, remember this old patch? I said it would take me a little while > > to get back to it... I didn't really expect it to be six months, > > though. > > > > Almost as much for the review....sorry. > > Much cleaner, thanks. > > There in an extra include of gdb_assert in symfile.c that is a left > over from the previous iteration. And ccould you add some comments > about what this new symfile_relocate_debug_section does (i.e > parameters, return value). Some of the explanations in your message > are good for comments too. > > other than that ok. Much thanks; checked in with better comments. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer