From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13188 invoked by alias); 30 Jan 2003 23:59:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13178 invoked from network); 30 Jan 2003 23:59:08 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 172.16.49.205 with SMTP; 30 Jan 2003 23:59:08 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18eQTI-0003Gq-00 for ; Thu, 30 Jan 2003 20:00:00 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18eOas-0002cO-00 for ; Thu, 30 Jan 2003 18:59:42 -0500 Date: Thu, 30 Jan 2003 23:59:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [RFA]: LOC_COMPUTED + abstracted dwarf2 evaluator, again Message-ID: <20030130235942.GA9973@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.1i X-SW-Source: 2003-01/txt/msg00823.txt.bz2 On Mon, Jul 08, 2002 at 01:02:59PM -0400, Daniel Berlin wrote: > For yer convenience, I rediffed it against the current gdb sources. > I'll update the changelog dates if it ever gets reviewed or approved. > Slightly updated accompanying text (from the april submission): > " > The only real things left to do is give some *real* description in > locexpr_describe_location, add tracepoint support, and remove the > dwarf2cfi.c evaluator . > None of these should be blockers to committing it or reviewing it. > > It would also be nice to use location expressions in *all* cases > (currently, it only does it for variables) so you can get rid of > decode_loc_desc, but i'll leave that for the next patch. > > There are a few lines that are too long (<10, i *think*), sorry about > that, i couldn't see an easy way to break them up and have them make > sense. > > Splitting this patch into loc_computed addition, and dwarf2 implementation > of loc_computed, doesn't make it much smaller (loc_computed_addition is > maybe 5% of the patch), so if size is a concern, sorry, but it's pretty > much unsplittable beyond that (the biggest portion is the addition of the > abstracted evaluator, but the dwarf2 implementation doesn't work without > it). > > This patch has been tested on both powerpc-linux and 686-linux. > " FYI, I've picked up this patch (well, an updated version Daniel sent me) and I intend to get it working and resubmitted. I've got it mostly passing the testsuite now (there were a couple of problems, with frames and such). The tracepoint test will fail until that bit is implemented, which I don't see as a blocker; I'll try to do that bit as a separate patch afterwards. I'm still working on cleaning up some bogosities, etc. etc., so it will be another day or two. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer