From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27989 invoked by alias); 29 Jan 2003 12:05:23 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27982 invoked from network); 29 Jan 2003 12:05:21 -0000 Received: from unknown (HELO copland.dzl.rws.minvenw.nl) (194.151.190.68) by 172.16.49.205 with SMTP; 29 Jan 2003 12:05:21 -0000 Received: from copland.dzl.rws.minvenw.nl (localhost [127.0.0.1]) by copland.dzl.rws.minvenw.nl (8.12.6/8.12.6) with ESMTP id h0TC5Lj1000652; Wed, 29 Jan 2003 13:05:21 +0100 (CET) (envelope-from m.kettenis@osp.nl) Received: (from kettenis@localhost) by copland.dzl.rws.minvenw.nl (8.12.6/8.12.6/Submit) id h0TC5LVv000649; Wed, 29 Jan 2003 13:05:21 +0100 (CET) Date: Wed, 29 Jan 2003 12:05:00 -0000 Message-Id: <200301291205.h0TC5LVv000649@copland.dzl.rws.minvenw.nl> X-Authentication-Warning: copland.dzl.rws.minvenw.nl: kettenis set sender to m.kettenis@osp.nl using -f From: Mark Kettenis To: gdb-patches@sources.redhat.com CC: ac131313@redhat.com, drow@mvista.com, hunt@redhat.com Subject: Re: RFA: always default to using the libiberty regex X-SW-Source: 2003-01/txt/msg00770.txt.bz2 Sorry for my late reply, but I was on vacation last week. First, Martin's patch isn't right as is; it should at least update the string that documents --without-included-regex. If we apply it, I'd also like to see a comment somewhere, presumably in configure.in, that says that we used to default to --without-included-regex on systems with version 2 of the GNU C library, but don't do that anymore since there are systems out there that have a badly performing GNU regex in libc. Anyway, the history about GDB prefering the installed regex is a bit blurred. We used to prefer the regex in libc on Linux systems. We discussed turning it off one time, but I remember serious opposition against it, so we left it on. However, apparently somewhere along the line the configuration stuff got broken, and we silently moved to always using the bundled regex. I recently fixed the configuration problem, such that we started using the regex in libc again on Linux systems. If it is easy to detect a broken regex implementation, we should add configury stuff to do so, otherwise we should just yank it as Martin's patch does. Mark