From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5228 invoked by alias); 28 Jan 2003 14:39:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5217 invoked from network); 28 Jan 2003 14:39:05 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 172.16.49.205 with SMTP; 28 Jan 2003 14:39:05 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18dYmB-0005cQ-00 for ; Tue, 28 Jan 2003 10:39:55 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18dWtg-000586-00 for ; Tue, 28 Jan 2003 09:39:32 -0500 Date: Tue, 28 Jan 2003 14:39:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: RFA: always default to using the libiberty regex Message-ID: <20030128143932.GA19699@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <1043715417.1134.7.camel@Dragon> <20030128033359.GA11366@nevyn.them.org> <3E369535.5040100@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3E369535.5040100@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-01/txt/msg00758.txt.bz2 On Tue, Jan 28, 2003 at 09:35:33AM -0500, Andrew Cagney wrote: > >On Mon, Jan 27, 2003 at 04:56:56PM -0800, Martin M. Hunt wrote: > > > >>This patch deletes the configure code to check the OS implementation of > >>regex and default to that. The default will now always be the builtin. > >> > >> > >>2003-01-27 Martin M. Hunt > >> > >> * configure.in: Revert check for system regex. Use builtin regex by > >>default. > >> * configure: Rebuilt. > >> > > > > > >I'm still not convinced this is a good idea. > > > >Context: it's a bug in the system's GNU C library, and should be fixed > >as such. All the rest of us who have a version of glibc which has this > >issue addressed don't have a problem, and I don't really want to carry > >around yet another statically linked copy of regex if I don't need to. > >Since it doesn't manifest on my system, I suspect it is fixed in glibc > >2.3.1; it's another piece of fallout from Red Hat's choice of using the > >brand-new barely-tested glibc 2.2.93 for their desktop product. > > There are several choices here: > > - GDB prefers the installed regex. > > This is what the current config is doing. > I think it is telling that the patch hasn't even been in for a month > and, already, we've hit problems. No matter where the problem is, it is > GDB that will get the blame. I also believe that way back when this was > last debated, specific regex releases were identified as problematic. > > > - GDB prefers the bundled regex. > > This is what the old config was doing. > Doing this means that GDB needs to, at regular intervals, upgrade that > code. We do this now for readline. It also means that the GDB > developers are insulated from problems with the utility libraries. > > > As best I can tell, the only people that really benefit from the system > regex are those making distros - it saves them the hassle of having to > remember --with-..regex=. GDB developers don't benefit - we all need to > specify the bundled regex as otherwize we can't reproduce each others > results (cf Martin's problem). GDB users don't benefit as they now get > a GDB of unknown quality. Put that way, the patch is OK with me. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer