Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@gnat.com>
To: bash-maintainers@gnu.org
Cc: gdb-patches@sources.redhat.com
Subject: Missing check for mbsrtowc causes compilation failure on HP/UX 11.11
Date: Tue, 28 Jan 2003 05:03:00 -0000	[thread overview]
Message-ID: <20030128050317.GH6437@gnat.com> (raw)

Dear readline maintainers,

I noticed a compilation failure in the readline module of the current
sources of GDB (extracted from CVS). This is occuring on HP/UX 11.11,
using GCC 3.2.1. I think that the readline version number used in GDB
is 4.3.

The compilation fails inside _rl_vi_change_mbchar_case (vi_mode.c)
because the compiler could not find mbrtowc. I searched this function,
and found that it is not provided by this system, but I could find
mbrtowcs. I then saw that _rl_vi_change_mbchar_case is compiled only
if HANDLE_MULTIBYTE is set. In turn, HANDLE_MULTIBYTE is set only if
(see rlmbutil.h):

    #if defined (HAVE_WCTYPE_H) && defined (HAVE_WCHAR_H)
    #  include <wchar.h>
    #  include <wctype.h>
    #  if defined (HAVE_MBSRTOWCS) /* system is supposed to support XPG5 */
    #    define HANDLE_MULTIBYTE      1
    #  endif
    #endif

It seems that configure is only checking for mbsrtowcs, but not mbsrtowc.
This works on HP/UX 11.00 where neither of these functions are provided,
but not on HP/UX 11.11 where mbsrtowcs is defined.

I therefore made the following change, where I added a check for mbsrtowc.
config.h.in has been updated accordingly. I also updated the condition in
rlmbutil.h to make sure both mbsrtowcs and mbsrtowc are available before
enabling multibyte.

The patch is attached.

Concerning copyright assignments, I am not sure what will be needed. The
company I work for has an assignment on file with the FSF for GDB work.
I hope this will be sufficient.

Changelog:

aclocal.m4
        - add check for mbsrtowc.

config.h.in
        - regenerate.

rlmbutil.h
        - make sure mbsrtowc is available before enabling multibyte support.

-- 
Joel Brobecker,
Ada Core Technologies, Inc.


             reply	other threads:[~2003-01-28  5:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-28  5:03 Joel Brobecker [this message]
2003-01-28  5:04 ` Joel Brobecker
2003-03-03  2:35   ` Elena Zannoni
2003-03-03 19:05     ` Joel Brobecker
2003-03-03 18:55   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030128050317.GH6437@gnat.com \
    --to=brobecker@gnat.com \
    --cc=bash-maintainers@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox