From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12523 invoked by alias); 27 Jan 2003 20:26:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12508 invoked from network); 27 Jan 2003 20:26:26 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 172.16.49.205 with SMTP; 27 Jan 2003 20:26:26 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18dHim-0003pE-00 for ; Mon, 27 Jan 2003 16:27:17 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18dFqG-0003Rw-00 for ; Mon, 27 Jan 2003 15:26:52 -0500 Date: Mon, 27 Jan 2003 20:26:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: Fix a goof in the profiling code Message-ID: <20030127202652.GA13126@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20030127143831.GA1282@nevyn.them.org> <3E358A39.9020300@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3E358A39.9020300@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-01/txt/msg00738.txt.bz2 On Mon, Jan 27, 2003 at 02:36:25PM -0500, Andrew Cagney wrote: > >+ warning ("Profiling support is not available on this system."); > > FYI, > > that should error(). I thought about this at the time and settled on warning, but my reasoning was pretty bogus now that I think about it. OK, changed. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer 2003-01-27 Daniel Jacobowitz * maint.c [! (HAVE_MONSTARTUP && HAVE__MCLEANUP)] (maintenance_set_profile_cmd): Use error () instead of warning (). Index: maint.c =================================================================== RCS file: /cvs/src/src/gdb/maint.c,v retrieving revision 1.32 diff -u -p -r1.32 maint.c --- maint.c 27 Jan 2003 14:36:56 -0000 1.32 +++ maint.c 27 Jan 2003 20:25:14 -0000 @@ -692,7 +692,7 @@ maintenance_set_profile_cmd (char *args, static void maintenance_set_profile_cmd (char *args, int from_tty, struct cmd_list_element *c) { - warning ("Profiling support is not available on this system."); + error ("Profiling support is not available on this system."); } #endif