From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9418 invoked by alias); 24 Jan 2003 11:13:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9408 invoked from network); 24 Jan 2003 11:13:08 -0000 Received: from unknown (HELO fw-cam.cambridge.arm.com) (193.131.176.3) by 172.16.49.205 with SMTP; 24 Jan 2003 11:13:08 -0000 Received: by fw-cam.cambridge.arm.com; id LAA10718; Fri, 24 Jan 2003 11:12:51 GMT Received: from unknown(172.16.1.2) by fw-cam.cambridge.arm.com via smap (V5.5) id xma009977; Fri, 24 Jan 03 11:12:01 GMT Received: from pc960.cambridge.arm.com (pc960.cambridge.arm.com [10.1.205.4]) by cam-admin0.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id LAA19486; Fri, 24 Jan 2003 11:11:59 GMT Received: from pc960.cambridge.arm.com (rearnsha@localhost) by pc960.cambridge.arm.com (8.11.6/8.9.3) with ESMTP id h0OBBxo13651; Fri, 24 Jan 2003 11:11:59 GMT Message-Id: <200301241111.h0OBBxo13651@pc960.cambridge.arm.com> X-Authentication-Warning: pc960.cambridge.arm.com: rearnsha owned process doing -bs To: Michael Snyder cc: Richard.Earnshaw@buzzard.freeserve.co.uk, gdb-patches@sources.redhat.com, rearnsha@arm.com Reply-To: Richard.Earnshaw@arm.com Organization: ARM Ltd. X-Telephone: +44 1223 400569 (direct+voicemail), +44 1223 400400 (switchbd) X-Fax: +44 1223 400410 X-Address: ARM Ltd., 110 Fulbourn Road, Cherry Hinton, Cambridge CB1 9NJ. Subject: Re: ARM PATCH fix extract_return_value and store_return_value In-reply-to: Your message of "Thu, 23 Jan 2003 19:10:17 PST." <3E30AE99.43801E0D@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 24 Jan 2003 11:13:00 -0000 From: Richard Earnshaw X-SW-Source: 2003-01/txt/msg00716.txt.bz2 > > 2002-12-14 Richard Earnshaw > > > > * arm-tdep.c (convert_from_extended): New argument to hold the > > type of floating point result we want to convert to. Make input > > argument const. Fix all callers. > > (convert_to_extended): Similarly. > > (arm_extract_return_value): Now takes a regcache argument. Change > > code to use regcache accessor functions. Correctly extract > > smaller-than-word results on big-endian machines. > > (arm_store_return_value): Now takes a regcache argument. Change > > code to use regcache accessor functions. Correctly zero/sign extend > > smaller than word results before storing into r0. > > (arm_gdbarch_init): Register new-style extract_return_value and > > store_return_value functions. > > Hi Richard, > > I can report that these > changes do fix two fails for big-endian running callfuncs.exp. > One of the fails was returning a one-byte struct, the other > a two-byte struct. There were no other fails in callfuncs.exp. Excellent. Thanks for doing the tests. > As is, they conflict with some of Elena's > vector changes, but I've massaged them into closer conformance > with a more recent revision. Here's my merged patch (not entirely > up to date, but more recent than what appears here). I installed the patches to the public tree back in December, so these conflicts must relate to some internal version you are testing on. R.