From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12698 invoked by alias); 23 Jan 2003 22:42:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12691 invoked from network); 23 Jan 2003 22:42:30 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 172.16.49.205 with SMTP; 23 Jan 2003 22:42:30 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18brwE-0000KF-00 for ; Thu, 23 Jan 2003 18:43:18 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18bq3b-0005uF-00 for ; Thu, 23 Jan 2003 17:42:47 -0500 Date: Thu, 23 Jan 2003 22:42:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [RFA] mips-tdep.c: Fix inferior function call breakage Message-ID: <20030123224247.GA22659@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <1030123072642.ZM24777@localhost.localdomain> <3E3057F0.5000906@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3E3057F0.5000906@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-01/txt/msg00706.txt.bz2 On Thu, Jan 23, 2003 at 04:00:32PM -0500, Andrew Cagney wrote: > >Without the following patch in place, I've found that inferior function > >calls are badly broken for the mips linux targets that I've been testing. > >(The warning in heuristic_proc_start() is tripped and things degrade > >quickly > >from there...) > > > >Okay? > > > > * mips-tdep.c (find_proc_desc): Return early if in a dummy frame. > > Hmm, explicit tests for PC in call-dummy set of alarm bells. > > Kevin, can you post a backtrace showing how the program came to be > there? Two alternative possabilities (in addition to this patch) are: > > - the code should not have been called (and the dummy-frame flow should > have gone elsewhere) > > - the code needs to be made per-frame How is via INIT_EXTRA_FRAME_INFO, already a legacy mechanism. Presumably someone could convert MIPS; although if no one's going to do that, we might want Kevin's change in the interim. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer