From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Received: (qmail 16243 invoked from network); 13 Jan 2003 03:21:25 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (80.13.18.153) by 209.249.29.67 with SMTP; 13 Jan 2003 03:21:25 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 17DEBD34AE; Mon, 13 Jan 2003 07:21:11 +0400 (RET) Date: Mon, 13 Jan 2003 03:21:00 -0000 From: Joel Brobecker To: Klee Dienes Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] (ping) GDB crash when using command lines due to memory corruption Message-ID: <20030113032110.GQ30359@gnat.com> References: <20021211173805.GG25575@gnat.com> <8096FEF2-0D32-11D7-9BDD-00039396EEB8@apple.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8096FEF2-0D32-11D7-9BDD-00039396EEB8@apple.com> User-Agent: Mutt/1.4i X-SW-Source: 2003-01/txt/msg00480.txt.bz2 There is a patch that was submitted on Oct 30th 2002 but hasn't been reviewed because it addresses a GDB crash. It also expands break.exp to test for this. Can somebody have a look please? Klee, I'll be happy to check it in for you if you lack the time. On Wed, Dec 11, 2002 at 01:00:58PM -0500, Klee Dienes wrote: > A safer change for 5.3 might be the patch I submitted on October 30th. > > http://sources.redhat.com/ml/gdb-patches/2002-10/msg00586.html > > Rather than deal with sharing the command-line structure, I just > updated bpstat_copy to match its comment, and do a deep copy of the > command lines as well as the value. I don't really have a strong > opinion about copying the command lines vs. managing them the way Joel > proposes, although my patch does have the argument of simplicity going > for it. On the other hand, if/when we go to a more sophistiated > command-line evaluator, we'll probably want the command body to be some > opaque and externally managed structure anyway. > > Whichever patch we end up taking, though, we should be sure to update > the comment in bpstat_copy and add my proposed change to the test suite. > -- Joel