From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Received: (qmail 13213 invoked from network); 11 Jan 2003 17:48:59 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 209.249.29.67 with SMTP; 11 Jan 2003 17:48:59 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18XRdH-00077z-00 for ; Sat, 11 Jan 2003 13:49:28 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18XPkw-0000W7-00 for ; Sat, 11 Jan 2003 12:49:14 -0500 Date: Sat, 11 Jan 2003 17:48:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [RFA] Replace SET_NAMESTRING macro by function in hpread.c Message-ID: <20030111174913.GA1930@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20030111093146.GL30359@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030111093146.GL30359@gnat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-01/txt/msg00451.txt.bz2 On Sat, Jan 11, 2003 at 01:31:46PM +0400, Joel Brobecker wrote: > In the name of macros-are-evil, as suggested by AndrewC, I replaced > the SET_NAMESTRING macro by a function... > > 2003-01-10 J. Brobecker > > * hpread.c (set_namestring): New procedure replacing the > SET_NAMESTRING macro. > (hpread_build_psymtabs): Replace calls to SET_NAMESTRING > by calls to set_namestring. > > Ok to apply? Yes, if... > + if (! hpread_has_name ((sym)->dblock.kind)) Please lose all the extra parentheses from the macro definition. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer