From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFC] trying to kill a warning in hpread.c (from call to complaint)
Date: Fri, 10 Jan 2003 16:13:00 -0000 [thread overview]
Message-ID: <20030110161332.GA8350@nevyn.them.org> (raw)
In-Reply-To: <3E1EF005.5060906@redhat.com>
On Fri, Jan 10, 2003 at 11:08:37AM -0500, Andrew Cagney wrote:
>
> >> complaint (&symfile_complaints, "bad string table offset in symbol
> >> %d", \
> >> (char *) symnum); \
> >> *NAMEP = ""; \
> >> } \
> >> else \
> >> *NAMEP = (SYM)->dsfile.name + VT (OBJFILE)
> >>
> >>I think that the warning comes from the call to complaint where the
> >>format string contains "%d", but the next parameter is casted to a
> >>"char *".
> >>
> >>Is the cast to "char *" necessary? Can/Should I remove it?
> >
> >
> >Looks like a typo in Kevin's complaint patch.
>
> Nope. The original code was broken:
>
> complain (&string_table_offset_complaint, (char *) symnum);
>
> (complaint -> complaints finds another victim / bug).
Agh! CVS logs foil me again!
No offense intended to Kevin.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
prev parent reply other threads:[~2003-01-10 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-10 14:26 Joel Brobecker
2003-01-10 14:34 ` Daniel Jacobowitz
2003-01-10 16:08 ` Andrew Cagney
2003-01-10 16:13 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030110161332.GA8350@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox