From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <brobecke@takamaka.act-europe.fr>
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Received: (qmail 23930 invoked from network); 10 Jan 2003 14:26:56 -0000
Received: from unknown (HELO takamaka.act-europe.fr) (193.253.46.184)
  by 209.249.29.67 with SMTP; 10 Jan 2003 14:26:56 -0000
Received: by takamaka.act-europe.fr (Postfix, from userid 507)
	id 89537D34AE; Fri, 10 Jan 2003 18:26:39 +0400 (RET)
Date: Fri, 10 Jan 2003 14:26:00 -0000
From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFC] trying to kill a warning in hpread.c (from call to complaint)
Message-ID: <20030110142639.GC30359@gnat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4i
X-SW-Source: 2003-01/txt/msg00398.txt.bz2

Hello,

I see the following warnings when compiling hpread.c:

        hpread.c:1920: warning: int format, pointer arg (arg 3)
        hpread.c:2025: warning: int format, pointer arg (arg 3)
        hpread.c:2051: warning: int format, pointer arg (arg 3)
        hpread.c:2072: warning: int format, pointer arg (arg 3)
        hpread.c:2146: warning: int format, pointer arg (arg 3)
        hpread.c:2230: warning: int format, pointer arg (arg 3)

These warnings point to the following macro:

#define SET_NAMESTRING(SYM, NAMEP, OBJFILE) \
  if (! hpread_has_name ((SYM)->dblock.kind)) \
    *NAMEP = ""; \
  else if (((unsigned)(SYM)->dsfile.name) >= VT_SIZE (OBJFILE)) \
    { \
      complaint (&symfile_complaints, "bad string table offset in symbol %d", \
                 (char *) symnum); \
      *NAMEP = ""; \
    } \
  else \
    *NAMEP = (SYM)->dsfile.name + VT (OBJFILE)

I think that the warning comes from the call to complaint where the
format string contains "%d", but the next parameter is casted to a
"char *".

Is the cast to "char *" necessary? Can/Should I remove it?

Thanks,
-- 
Joel