From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Received: (qmail 29448 invoked from network); 9 Jan 2003 19:02:49 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 209.249.29.67 with SMTP; 9 Jan 2003 19:02:49 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18Wjpc-0002UH-00 for ; Thu, 09 Jan 2003 15:03:16 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18WhxF-0008NU-00 for ; Thu, 09 Jan 2003 14:03:01 -0500 Date: Thu, 09 Jan 2003 19:02:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: PATCH: --with-sysroot for GDB Message-ID: <20030109190301.GA32189@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20030109173810.GA19919@nevyn.them.org> <1030109183659.ZM22146@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1030109183659.ZM22146@localhost.localdomain> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-01/txt/msg00378.txt.bz2 On Thu, Jan 09, 2003 at 11:37:00AM -0700, Kevin Buettner wrote: > On Jan 9, 12:38pm, Daniel Jacobowitz wrote: > > > Thoughts? I'll look to apply this in a couple of days if no one > > objects to the way I implemented it. > > > > > > 2003-01-09 Daniel Jacobowitz > > > > * Makefile.in (TARGET_SYSTEM_ROOT, TARGET_SYSTEM_ROOT_DEFINE): New > > variables. > > (main.o): Custom rule which uses $(TARGET_SYSTEM_ROOT_DEFINE). > > * configure.in: Add --with-sysroot. > > * main.c (gdb_sysroot): New variable. > > (captured_main): Initialize gdb_sysroot. > > * defs.h (gdb_sysroot): New extern declaration. > > You missed a ChangeLog entry for solib.c, but I've looked over that part > of the patch and it looks good. (But do write a ChangeLog entry for it.) Oops, thanks for spotting that! Will fix before I check it in. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer