Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Richard Earnshaw <rearnsha@arm.com>
To: Michael Snyder <msnyder@redhat.com>
Cc: Richard.Earnshaw@arm.com, Fernando Nasser <fnasser@redhat.com>,
	gdb-patches@sources.redhat.com, rearnsha@arm.com,
	cagney@redhat.com, kevinb@redhat.com,
	fnasser <fnasser@tooth.toronto.redhat.com>
Subject: Re: [RFA] arm_extract_return_value, big-endian
Date: Wed, 08 Jan 2003 09:48:00 -0000	[thread overview]
Message-ID: <200301080947.h089llm10487@pc960.cambridge.arm.com> (raw)
In-Reply-To: Your message of "Tue, 07 Jan 2003 15:46:04 PST." <3E1B66BC.B5D75FEA@redhat.com>

> Richard Earnshaw wrote:
> > 
> > fnasser@redhat.com said:
> > > Humm..., I am having second thoughts about this.  Isn't the problem
> > > you  are seeing the same problem of not having the values peoperly
> > > sign-extended?
> > 
> > No.  In this case we really need to copy the least significant 1 (or 2)
> > bytes into the 1 or 2 bytes in the valbuf target.  That means doing a copy
> > from the higher addresses.   So in that respect, the patch is correct.
> > 
> > But it breaks the case where the return value is more than one word.
> 
> Yes, I see that now.  Richard, how about a joint effort?
> Would you be so kind as to fill in the empty else clause?

I think I've already fixed this.  Did you miss my request that you test it 
for me on a big-endian system?


http://sources.redhat.com/ml/gdb-patches/2002-12/msg00444.html

R.


      reply	other threads:[~2003-01-08  9:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-06 13:30 Michael Snyder
2002-12-03  7:33 ` Fernando Nasser
2002-12-03  7:41 ` Fernando Nasser
2002-12-04  2:02   ` Richard Earnshaw
2003-01-07 23:46     ` Michael Snyder
2003-01-08  9:48       ` Richard Earnshaw [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200301080947.h089llm10487@pc960.cambridge.arm.com \
    --to=rearnsha@arm.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=cagney@redhat.com \
    --cc=fnasser@redhat.com \
    --cc=fnasser@tooth.toronto.redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    --cc=msnyder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox