From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3851 invoked by alias); 8 Jan 2003 00:47:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3843 invoked from network); 8 Jan 2003 00:47:50 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 209.249.29.67 with SMTP; 8 Jan 2003 00:47:50 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18W6GK-00072D-00; Tue, 07 Jan 2003 20:48:12 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18W4Nt-0007sx-00; Tue, 07 Jan 2003 19:47:53 -0500 Date: Wed, 08 Jan 2003 00:47:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: Michael Elizabeth Chastain , gdb-patches@sources.redhat.com Subject: Re: RFC: Slay COERCE_FLOAT_TO_DOUBLE Message-ID: <20030108004753.GA30295@nevyn.them.org> Mail-Followup-To: Andrew Cagney , Michael Elizabeth Chastain , gdb-patches@sources.redhat.com References: <200301071800.h07I0H027120@duracef.shout.net> <3E1B6E90.2010809@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3E1B6E90.2010809@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-01/txt/msg00310.txt.bz2 On Tue, Jan 07, 2003 at 07:19:28PM -0500, Andrew Cagney wrote: > > >Daniel's patch keeps the current data structure, which uses 1 bit > >to indicate whether the function is prototyped or not. > > > >I prefer to use 2 bits: TYPE_PROTO_KNOWN and TYPE_PROTO_YES. > >That allows for three states: > > > > known=0 gdb does not know if function is prototyped > > known=1, yes=0 function is definitely not prototyped > > known=1, yes=1 function is definitely prototyped > > > >I have written such a 2-bit patch. > > To be pedantic :-) That's an enum with three states: > > prototype unknown > prototyped > unprototyped > > It can be packed into two bits. If we want to go this way, then it should probably be done with four states anyway: User prototyped vs. not Type is declared-as vs. called-as I didn't do this because the usefulness of the extra information is pretty minor; but we certainly could do it. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer