From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19161 invoked by alias); 4 Jan 2003 04:43:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19153 invoked from network); 4 Jan 2003 04:43:54 -0000 Received: from unknown (HELO redhat.com) (66.30.22.225) by 209.249.29.67 with SMTP; 4 Jan 2003 04:43:54 -0000 Received: by redhat.com (Postfix, from userid 201) id 000BF1C10F; Fri, 3 Jan 2003 23:44:08 -0500 (EST) Date: Sat, 04 Jan 2003 04:43:00 -0000 From: Christopher Faylor To: gdb-patches@sources.redhat.com Cc: RaoulGough@yahoo.co.uk Subject: Re: coffread.c extension for DLLs without debugging symbols Message-ID: <20030104044408.GA7364@redhat.com> Mail-Followup-To: gdb-patches@sources.redhat.com, RaoulGough@yahoo.co.uk References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.1i X-SW-Source: 2003-01/txt/msg00142.txt.bz2 On Fri, Jan 03, 2003 at 07:39:31PM -0000, Raoul Gough wrote: >Proposed ChangeLog entry, assuming the code is accepted: > >2003-01-03 Raoul Gough > > * coffread.c: Support non-debug export symbols for win32 DLLs WONDERFUL! I would love to have this code in the windows version of gdb. I've often thought about doing something like this but I've never had the stamina to look into what it would take to do this. I have a few comments. 0) The ChangeLog needs more information. Every new function should be mentioned and changes to specific functions should be documented. 1) AFAICT, the formatting of the code looks great (a rarity for a first timer) except for an odd comment or two which doesn't end in a "." as required for a complete sentence. Yeah, yeah, a total nit but hey we've got standards! 2) I wonder if this code should be ifdef'ed somehow for Windows since it will add extra code for no gain on every COFF platform. Of course, how many of those are there out there? Maybe this isn't a huge issue after all. 3) objdump -p already has the ability to read and report on the export table. I wonder if it would be useful (or possible) to generalize this code so that gdb and objdump would be using the same base. I haven't looked too closely but I think the code in question is in bfd/peicode.h. Hmm. Maybe objdump isn't interested in the kinds of things that gdb is, though, like what section a symbol is associated with... Anyway, I'll be giving this an actual test run in the next couple of days. In the meantime, THANK YOU for doing this. Even given the very minor above points, I think this will be a great boon for the Windows version of gdb. This will help enormously in debugging on Windows. You will definitely need to get an assignment in to the FSF, though, unfortunately. I think jimb at redhat dot com is the person to help you with that. cgf P.S. Assuming that this works as advertised, I assume that you will have no objections to my releasing a new version of gdb for windows with this patch in it before the patch makes its way into the official gdb repository, right? I think there are a few users in the cygwin mailing list that would appreciate this change. -- Special for spam email harvesters: send email to aaaspam@sources.redhat.com and be permanently blocked from mailing lists at sources.redhat.com.