From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20955 invoked by alias); 4 Jan 2003 01:54:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20948 invoked from network); 4 Jan 2003 01:54:01 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 209.249.29.67 with SMTP; 4 Jan 2003 01:54:01 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18UfOA-0003WY-00; Fri, 03 Jan 2003 21:54:22 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18UdVc-0006CB-00; Fri, 03 Jan 2003 20:53:56 -0500 Date: Sat, 04 Jan 2003 01:54:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [RFA/PATCH] breakpoint.c: fix until command Message-ID: <20030104015356.GA23728@nevyn.them.org> Mail-Followup-To: Michael Snyder , Elena Zannoni , gdb-patches@sources.redhat.com References: <3E14A019.4A600913@redhat.com> <15892.41806.882466.952438@localhost.redhat.com> <15892.54871.381942.260248@localhost.redhat.com> <3E14EB0A.15D7724E@redhat.com> <20030103015102.GA8209@nevyn.them.org> <3E14F768.DA13CB07@redhat.com> <15893.40776.758960.171190@localhost.redhat.com> <3E1621FF.A822AD5C@redhat.com> <15894.9086.849437.238762@localhost.redhat.com> <3E162537.63F529DF@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3E162537.63F529DF@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-01/txt/msg00137.txt.bz2 On Fri, Jan 03, 2003 at 04:05:11PM -0800, Michael Snyder wrote: > Well then... > 1) Use find_pc_partial_function to determine bounds and > distinguish between in-bounds and out-of-bounds locations. > 2) For func_start > loc >= func_end, use a frame-relative bp. > 3) For func_start == loc or loc < func_start or loc > func_end, > use a frameless bp. > 4) document, document, document! > Including the recursive corner case. > > Agreed, Elena? So you're saying: - if the PC is in this function, only stop when this frame reaches it. - if the PC is the _beginning_ of a function (what about prologue skipping, does that come into this? I don't remember if decode_line_1 will skip the prologue, but I think it will.) or in some other function, stop in any frame. > Daniel? Michael? I'd be happier if those two behaviors had different names, but the logical name I'd give to both of them is "until", so I guess we'll just have to live with this. (3) is meaningful when inside the function too, and with this scheme there's no way to express that without using breakpoints; but I think that's a small loss. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer