Re: [patch/rfc] KFAIL gdb.c++/annota2.exp watch triggered on a.x

Michael Elizabeth Chastain
2003-01-03T23:19:17Z

Daniel J says:
> OK; you're definitely right. How about a compromise: we agree not to
> remove kfail patterns in the testsuite, but instead replace them with
> specific fail patterns and a commented out reference to the failure.
> That makes life much simpler.

That sounds good to me.

Before the bug fix:

-re "known bad pattern" {
kfail "gdb/38" "test name"
}

After the bug fix:

-re "known bad pattern" {
# this was pr gdb/38
fail "test name"
}

If somebody leaves a KFAIL pointing to a closed bug, and the KFAIL
fires, then eventually somebody will notice that the KFAIL points to
a closed bug -- which means that the bug has re-appeared. The bug ID#
then provides valuable history.

If somebody applies the 'bug fix' too soon, or it doesn't work in
all cases, then the person investigating it will see the comment
about "gdb 38" in the test script source pretty quickly.

Michael C