Re: [RFA/PATCH] breakpoint.c: fix until command

Daniel Jacobowitz
2003-01-04T01:54:01Z

On Fri, Jan 03, 2003 at 04:05:11PM -0800, Michael Snyder wrote:
> Well then...
> 1) Use find_pc_partial_function to determine bounds and
> distinguish between in-bounds and out-of-bounds locations.
> 2) For func_start > loc >= func_end, use a frame-relative bp.
> 3) For func_start == loc or loc < func_start or loc > func_end,
> use a frameless bp.
> 4) document, document, document!
> Including the recursive corner case.
>
> Agreed, Elena?

So you're saying:
- if the PC is in this function, only stop when this frame reaches it.
- if the PC is the _beginning_ of a function (what about prologue
skipping, does that come into this? I don't remember if
decode_line_1 will skip the prologue, but I think it will.) or in
some other function, stop in any frame.

> Daniel? Michael?

I'd be happier if those two behaviors had different names, but the
logical name I'd give to both of them is "until", so I guess we'll just
have to live with this. (3) is meaningful when inside the function
too, and with this scheme there's no way to express that without using
breakpoints; but I think that's a small loss.

--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer