Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Elizabeth Chastain <mec@shout.net>
To: drow@mvista.com, gdb-patches@sources.redhat.com
Subject: Re: [RFA/testsuite] Suppress errors building thread tests
Date: Tue, 31 Dec 2002 13:31:00 -0000	[thread overview]
Message-ID: <200212311902.gBVJ23j24532@duracef.shout.net> (raw)

Recommended for self-approval by Daniel J.

Proofread and tested.  All the pthreads library noise is gone
from gdb.sum.  The results for gcore-thread.exp, print-threads.exp,
and schedlock.exp are fine.

> Note the use of gdb_suppress_entire_file.  I'm just doing that because it's
> what the other tests do; I really dislike gdb_suppress_entire_file, so I
> think I may send along a followup patch to change it to a "return -1". 
> gdb_compile_pthreads already does an "unsupported" if compilation fails. If
> we can't build the threads tests, there's no point in FAILing them, in my
> opinion; this clutters up results when I run simulator testing.  Thoughts?

I'm with you.  If compilation+linking fails, I am fine with one
UNSUPPORTED per test script.  It would be even better if the UNSUPPORTED's
come from a known unsupported list rather than dynamic conditions.

Michael C

===

  2002-12-31  Daniel Jacobowitz  <drow@mvista.com>

	  Fix PR gdb/844
	  * lib/gdb.exp (gdb_compile): Handle "quiet" option.
	  (gdb_compile_pthreads): Pass "quiet" to gdb_compile.

	  * gdb.threads/gcore-thread.exp: Use gdb_compile_pthreads.
	  * gdb.threads/print-threads.exp: Likewise.
	  * gdb.threads/schedlock.exp: Likewise.


             reply	other threads:[~2002-12-31 19:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-31 13:31 Michael Elizabeth Chastain [this message]
2003-01-02 19:58 ` Michael Snyder
2003-01-04 23:06   ` Daniel Jacobowitz
  -- strict thread matches above, loose matches on Subject: below --
2002-12-31 10:02 Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200212311902.gBVJ23j24532@duracef.shout.net \
    --to=mec@shout.net \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox