From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22053 invoked by alias); 31 Dec 2002 10:57:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22038 invoked from network); 31 Dec 2002 10:57:03 -0000 Received: from unknown (HELO mail.cs.umass.edu) (128.119.243.168) by 209.249.29.67 with SMTP; 31 Dec 2002 10:57:03 -0000 Received: from localhost (IDENT:0Wpf4yc3gYirxprGYyg7kF5uK1ZMvS6Q@loki.cs.umass.edu [128.119.243.168]) by mail.cs.umass.edu (8.12.6/8.12.5) with ESMTP id gBVAu9lU030993; Tue, 31 Dec 2002 05:56:09 -0500 Date: Tue, 31 Dec 2002 04:42:00 -0000 Message-Id: <20021231.055606.107920012.kazu@cs.umass.edu> To: dvenkat@noida.hcltech.com Cc: gdb-patches@sources.redhat.com, newlib@sources.redhat.com Subject: Re: PATCH : H8300 Simulator File I/O Implementation From: Kazu Hirata In-Reply-To: References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Checked: This message probably not SPAM X-Spam-Score: -3.4, Required: 5 X-Spam-Tests: IN_REP_TO X-Spam-Report: SPAM: -3.4 hits, 5 required; SPAM: * -3.4 -- Found a In-Reply-To header X-Scanned-By: MIMEDefang 2.26 (www . roaringpenguin . com / mimedefang) X-SW-Source: 2002-12/txt/msg00763.txt.bz2 Hi Venky, > Based on some suggestions from Kazu Hirata, I have made some > changes. The patch to binutils has already been applied so I am > not attaching the same. The file newlib_patch.txt contains the > changes required in newlib/libc/sys/h8300hms/syscalls.c and > newlib/libc/sys/h8300hms/Makefile.in. the file > simulator_patch.txt contains the changes required in > sim/h8300/compile.c. Thank you for the updates. It would be nice if you could include a one-line comment describing a prototype in each .S file like ; int _close (int file); For one thing, doing so is sort of a convention for assembly functions to be called by C. Another reason is that H8 port uses registers for argument passing, making it difficult to see exactly how many arguments are being passed. This may be good for you, too, as _lseek requires two zero extensions, and you might want to remind yourself which arguments are of int. One nit picking: Do you still need the following in syscalls.c? + #include "sys/syscall.h" Meanwhile, I'll try your patches. Kazu Hirata