Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Add support for 64-bit MIPS GNU/Linux targets
Date: Tue, 24 Dec 2002 12:09:00 -0000	[thread overview]
Message-ID: <20021224194011.GA2004@nevyn.them.org> (raw)
In-Reply-To: <1021224192935.ZM27391@localhost.localdomain>

On Tue, Dec 24, 2002 at 12:29:35PM -0700, Kevin Buettner wrote:
> On Dec 24,  9:53am, Daniel Jacobowitz wrote:
> 
> > > I'll fix the GDBSERVER_DEPFILES and tm-linux64 nits, but the
> > > supply_gregset issue will require further discussion.  In the interim,
> > > how would you like to proceed?
> > 
> > Since it won't affect thread support for 32-bit MIPS, I've no objection
> > to committing it now.
> 
> Okay, it's in.  In addition to fixing the problems previously discussed,
> I found it necessary to change the osabi registration (in mips-linux-tdep.c)
> from:
> 
>   gdbarch_register_osabi (bfd_arch_mips, 0, GDB_OSABI_LINUX,
>                           mips_linux_init_abi);
> 
> to:
> 
>   for (arch_info = bfd_lookup_arch (bfd_arch_mips, 0);
>        arch_info != NULL;
>        arch_info = arch_info->next)
>     {
>       gdbarch_register_osabi (bfd_arch_mips, arch_info->mach, GDB_OSABI_LINUX,
>                               mips_linux_init_abi);
>     }
> 
> I'm not entirely happy with this change, but I see no way around it
> due to the recent changes to osabi.c.  (I'm open to suggestions for
> better ways to do it...)

OK, that's a problem.  In fact it's disgusting...  A mach value of 0 is
always supposed to mean "default", if I remember my BFD correctly.  Has
the change to pass a machine of 0 broken osabi support for anything
that sets a machine?  It looks that way.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2002-12-24 19:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-23 15:07 Kevin Buettner
2002-12-23 16:01 ` Daniel Jacobowitz
2002-12-23 22:37   ` Kevin Buettner
2002-12-24  9:25     ` Daniel Jacobowitz
2002-12-24 11:37       ` Kevin Buettner
2002-12-24 12:09         ` Daniel Jacobowitz [this message]
2002-12-24 19:25           ` Kevin Buettner
2003-01-07  0:26   ` Andrew Cagney
2003-01-07 23:16     ` Daniel Jacobowitz
2003-01-08  0:00       ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021224194011.GA2004@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox