From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23983 invoked by alias); 24 Dec 2002 00:01:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23976 invoked from network); 24 Dec 2002 00:01:05 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 209.249.29.67 with SMTP; 24 Dec 2002 00:01:05 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18QeNl-0005Mg-00; Mon, 23 Dec 2002 20:01:21 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18QcWR-00029s-00; Mon, 23 Dec 2002 19:02:11 -0500 Date: Mon, 23 Dec 2002 16:13:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [RFA/PATCH] breakpoint.c: fix until command Message-ID: <20021224000211.GA8155@nevyn.them.org> Mail-Followup-To: Michael Snyder , Elena Zannoni , gdb-patches@sources.redhat.com References: <15875.24035.153991.390184@localhost.redhat.com> <3E07A1F2.E7B77C89@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3E07A1F2.E7B77C89@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-12/txt/msg00652.txt.bz2 On Mon, Dec 23, 2002 at 03:53:22PM -0800, Michael Snyder wrote: > Elena Zannoni wrote: > > > > This fixes the problem reported in: > > http://sources.redhat.com/ml/gdb/2002-11/msg00144.html > > > > testsuite patch coming > > Elena, can you sum up in a sentence or two, what this change > is intended to do? [Since I happen to be reading email right now, I'll do a sketchy imitation.] The problem is that we were marking the breakpoint on the user-specified line with the current frame. But when we hit that breakpoint, if it's in a different function, it will have a different frame. Right now we see that the frames don't match and resume executing. Oops. > > Thanks, > Michael > > > > > 2002-12-20 Elena Zannoni > > > > Fix PR breakpoints/898. > > * breakpoint.c (until_break_command): Don't use selected_frame, > > but the null frame. > > > > Index: breakpoint.c > > =================================================================== > > RCS file: /cvs/uberbaum/gdb/breakpoint.c,v > > retrieving revision 1.104 > > diff -u -p -r1.104 breakpoint.c > > --- breakpoint.c 17 Dec 2002 17:27:44 -0000 1.104 > > +++ breakpoint.c 20 Dec 2002 18:06:27 -0000 > > @@ -5615,9 +5615,7 @@ until_break_command (char *arg, int from > > > > resolve_sal_pc (&sal); > > > > - breakpoint = > > - set_momentary_breakpoint (sal,get_frame_id (deprecated_selected_frame), > > - bp_until); > > + breakpoint = set_momentary_breakpoint (sal, null_frame_id, bp_until); > > > > if (!event_loop_p || !target_can_async_p ()) > > old_chain = make_cleanup_delete_breakpoint (breakpoint); > -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer