From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20228 invoked by alias); 23 Dec 2002 17:08:28 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20221 invoked from network); 23 Dec 2002 17:08:27 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 209.249.29.67 with SMTP; 23 Dec 2002 17:08:27 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18QXwS-0004mp-00 for ; Mon, 23 Dec 2002 13:08:44 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18QW55-0006S6-00 for ; Mon, 23 Dec 2002 12:09:31 -0500 Date: Mon, 23 Dec 2002 10:21:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: Patch: gdb/config/pa/nm-hppah.h: Warning removal Message-ID: <20021223170931.GA18312@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20021223095058.GA5665@urtur> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021223095058.GA5665@urtur> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-12/txt/msg00640.txt.bz2 On Mon, Dec 23, 2002 at 08:50:58PM +1100, rdbrown@mira.net wrote: > Eliminate warnings of the following form on hppa2.0n-hp-hpux11.00. > > gcc -c -g -O2 -D__HP_CURSES -Dvfork=fork -I. -I../../gdb+dejagnu-20021220/gdb \ > -I../../gdb+dejagnu-20021220/gdb/config \ > -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H \ > -I../../gdb+dejagnu-20021220/gdb/../include/opcode \ > -I../../gdb+dejagnu-20021220/gdb/../readline/.. \ > -I../bfd -I../../gdb+dejagnu-20021220/gdb/../bfd \ > -I../../gdb+dejagnu-20021220/gdb/../include -I../intl \ > -I../../gdb+dejagnu-20021220/gdb/../intl -DMI_OUT=1 -DUI_OUT=1 \ > -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses \ > -Wpointer-arith - Wuninitialized ../../gdb+dejagnu-20021220/gdb/main.c > In file included from tm.h:87, > from ../../gdb+dejagnu-20021220/gdb/defs.h:776, > from ../../gdb+dejagnu-20021220/gdb/main.c:23: > ../../gdb+dejagnu-20021220/gdb/config/pa/tm-hppa.h:324:1: warning: \ > "CANNOT_STORE_REGISTER" redefined > In file included from nm.h:23, > from ../../gdb+dejagnu-20021220/gdb/defs.h:768, > from ../../gdb+dejagnu-20021220/gdb/main.c:23: > ../../gdb+dejagnu-20021220/gdb/config/pa/nm-hppah.h:59:1: warning: \ > this is the location of the previous definition > > gdb/config/pa/tm-hppa.h now declares CANNOT_STORE_REGISTER as > hppa_cannot_store_register so delete the old inline definition. > Other duplicate definitions are in the follow two files. > > gdb/config/pa/nm-hppab.h:#define CANNOT_STORE_REGISTER(regno) > gdb/config/pa/nm-hppao.h:#define CANNOT_STORE_REGISTER(regno) > > (Copyright assigned.) > > 2002-12-23 Rodney Brown > > * config/pa/nm-hppah.h: Delete duplicate CANNOT_STORE_REGISTER decl. Thanks for the reminder; I've been meaning to do this for a month... I committed the following. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer 2002-12-23 Daniel Jacobowitz * config/pa/nm-hppab.h: Delete duplicate CANNOT_STORE_REGISTER decl. * config/pa/nm-hppao.h: Delete duplicate CANNOT_STORE_REGISTER decl. 2002-12-23 Rodney Brown * config/pa/nm-hppah.h: Delete duplicate CANNOT_STORE_REGISTER decl. Index: config/pa/nm-hppab.h =================================================================== RCS file: /cvs/src/src/gdb/config/pa/nm-hppab.h,v retrieving revision 1.3 diff -u -p -r1.3 nm-hppab.h --- config/pa/nm-hppab.h 14 Mar 2001 23:23:14 -0000 1.3 +++ config/pa/nm-hppab.h 23 Dec 2002 17:06:44 -0000 @@ -1,5 +1,5 @@ /* HPPA PA-RISC machine native support for BSD, for GDB. - Copyright 1991, 1992, 1993, 1994, 1995 Free Software Foundation, Inc. + Copyright 1991, 1992, 1993, 1994, 1995, 2002 Free Software Foundation, Inc. This file is part of GDB. @@ -37,20 +37,6 @@ with five arguments, so programs written for normal ptrace lose. */ #define FIVE_ARG_PTRACE - -/* This macro defines the register numbers (from REGISTER_NAMES) that - are effectively unavailable to the user through ptrace(). It allows - us to include the whole register set in REGISTER_NAMES (inorder to - better support remote debugging). If it is used in - fetch/store_inferior_registers() gdb will not complain about I/O errors - on fetching these registers. If all registers in REGISTER_NAMES - are available, then return false (0). */ - -#define CANNOT_STORE_REGISTER(regno) \ - ((regno) == 0) || \ - ((regno) == PCSQ_HEAD_REGNUM) || \ - ((regno) >= PCSQ_TAIL_REGNUM && (regno) < IPSW_REGNUM) || \ - ((regno) > IPSW_REGNUM && (regno) < FP4_REGNUM) /* fetch_inferior_registers is in hppab-nat.c. */ #define FETCH_INFERIOR_REGISTERS Index: config/pa/nm-hppah.h =================================================================== RCS file: /cvs/src/src/gdb/config/pa/nm-hppah.h,v retrieving revision 1.10 diff -u -p -r1.10 nm-hppah.h --- config/pa/nm-hppah.h 12 Dec 2002 01:39:34 -0000 1.10 +++ config/pa/nm-hppah.h 23 Dec 2002 17:06:44 -0000 @@ -1,5 +1,5 @@ /* Native support for HPPA-RISC machine running HPUX, for GDB. - Copyright 1991, 1992, 1994, 1996, 1998, 1999, 2000 + Copyright 1991, 1992, 1994, 1996, 1998, 1999, 2000, 2002 Free Software Foundation, Inc. This file is part of GDB. @@ -47,20 +47,6 @@ appropriate ptrace operator to manipulate text. Simply reading/writing user space will crap out HPUX. */ #define NEED_TEXT_START_END 1 - -/* This macro defines the register numbers (from REGISTER_NAMES) that - are effectively unavailable to the user through ptrace(). It allows - us to include the whole register set in REGISTER_NAMES (inorder to - better support remote debugging). If it is used in - fetch/store_inferior_registers() gdb will not complain about I/O errors - on fetching these registers. If all registers in REGISTER_NAMES - are available, then return false (0). */ - -#define CANNOT_STORE_REGISTER(regno) \ - ((regno) == 0) || \ - ((regno) == PCSQ_HEAD_REGNUM) || \ - ((regno) >= PCSQ_TAIL_REGNUM && (regno) < IPSW_REGNUM) || \ - ((regno) > IPSW_REGNUM && (regno) < FP4_REGNUM) /* In hppah-nat.c: */ #define FETCH_INFERIOR_REGISTERS Index: config/pa/nm-hppao.h =================================================================== RCS file: /cvs/src/src/gdb/config/pa/nm-hppao.h,v retrieving revision 1.3 diff -u -p -r1.3 nm-hppao.h --- config/pa/nm-hppao.h 5 Jun 2002 19:18:26 -0000 1.3 +++ config/pa/nm-hppao.h 23 Dec 2002 17:06:44 -0000 @@ -1,5 +1,5 @@ /* HPPA PA-RISC machine native support for Lites, for GDB. - Copyright 1995 Free Software Foundation, Inc. + Copyright 1995, 2002 Free Software Foundation, Inc. This file is part of GDB. @@ -26,20 +26,6 @@ /* What a coincidence! */ #define REGISTER_U_ADDR(addr, blockend, regno) \ { addr = (int)(blockend) + REGISTER_BYTE (regno);} - -/* This macro defines the register numbers (from REGISTER_NAMES) that - are effectively unavailable to the user through ptrace(). It allows - us to include the whole register set in REGISTER_NAMES (inorder to - better support remote debugging). If it is used in - fetch/store_inferior_registers() gdb will not complain about I/O errors - on fetching these registers. If all registers in REGISTER_NAMES - are available, then return false (0). */ - -#define CANNOT_STORE_REGISTER(regno) \ - ((regno) == 0) || \ - ((regno) == PCSQ_HEAD_REGNUM) || \ - ((regno) >= PCSQ_TAIL_REGNUM && (regno) < IPSW_REGNUM) || \ - ((regno) > IPSW_REGNUM && (regno) < FP4_REGNUM) /* fetch_inferior_registers is in hppab-nat.c. */ #define FETCH_INFERIOR_REGISTERS