From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23419 invoked by alias); 16 Dec 2002 16:57:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23405 invoked from network); 16 Dec 2002 16:57:12 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 16 Dec 2002 16:57:12 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18O0Qp-00046e-00; Mon, 16 Dec 2002 12:57:35 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18NyZI-0004Yh-00; Mon, 16 Dec 2002 11:58:12 -0500 Date: Mon, 16 Dec 2002 09:01:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: Michael Snyder , gdb-patches@sources.redhat.com Subject: Re: [PATCH] improved error message Message-ID: <20021216165812.GB17039@nevyn.them.org> Mail-Followup-To: Andrew Cagney , Michael Snyder , gdb-patches@sources.redhat.com References: <200212132326.gBDNQdAm009198@to-limbo.toronto.redhat.com> <3DFDFE7C.3060100@redhat.com> <20021216163625.GB16417@nevyn.them.org> <3DFE0378.7080902@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3DFE0378.7080902@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-12/txt/msg00477.txt.bz2 On Mon, Dec 16, 2002 at 11:46:48AM -0500, Andrew Cagney wrote: > >On Mon, Dec 16, 2002 at 11:25:32AM -0500, Andrew Cagney wrote: > > > >>>There are like five places in thread-db.c that all give the same > >>>error message. This just adds the function name, so you have a > >>>chance of figuring out where the error occurred. > >>> > >>>2002-12-13 Michael Snyder > >>> > >>> * thread-db.c (thread_from_lwp): Uniquify error msg. > >>> (lwp_from_thread): Ditto. > >>> (check_event): Ditto. > >>> (find_new_threads_callback): Ditto. > >>> (thread_db_pid_to_str): Ditto. > > > >> > >>Er, this looks wrong. A normal user visible error message should not > >>include references to internal function names. Can you either reword > >>the messages or, perhaphs, add a debug mode that displys this additional > >>information? > > > > > >These are essentially internal error messages - none of them should > >ever happen. They do now, of course. > > > >IMVHO I like Michael's change; now when people report these error > >messages I'll know automatically which one they are. They tend to be > >only spontaneously reproducible. > > If it is a internal error, call internal_error(). >From a practicality viewpoint, I refuse to do that when we know of multiple situations which trigger these problems. I still get them reported to me every couple of weeks. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer