From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Cc: msnyder@redhat.com, kettenis@gnu.org
Subject: RFA[threads]: Fork event updates, part the thirteenth
Date: Sun, 15 Dec 2002 13:43:00 -0000 [thread overview]
Message-ID: <20021215213952.GA3923@nevyn.them.org> (raw)
Now is where it starts to get interesting. Michael, I mentioned this patch
to you at lunch last week. If you take a short-lived program, run it, and
detach it, and run it again, you'll see the exit of the _previous_ copy.
Then GDB gets hopelessly confused. I have a testcase for this which I'll
post in a moment.
The reason it's included here is that that's essentially what happens if you
are using "set follow-fork-mode child". We detach from the parent, which
exits, confusing GDB.
Is this OK?
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
2002-12-15 Daniel Jacobowitz <drow@mvista.com>
* lin-lwp.c (child_wait): Ignore exit statuses for processes other
than inferior_ptid.
(lin_lwp_wait): Ignore exit statuses for unknown LWPs.
Index: lin-lwp.c
===================================================================
RCS file: /cvs/src/src/gdb/lin-lwp.c,v
retrieving revision 1.39
diff -u -p -r1.39 lin-lwp.c
--- lin-lwp.c 9 Dec 2002 18:41:42 -0000 1.39
+++ lin-lwp.c 15 Dec 2002 21:16:34 -0000
@@ -964,6 +964,14 @@ child_wait (ptid_t ptid, struct target_w
pid = waitpid (GET_PID (ptid), &status, __WCLONE);
save_errno = errno;
+ /* Make sure we don't report an event for the exit of the
+ original program, if we've detached from it. */
+ if (pid != -1 && ! WIFSTOPPED (status) && pid != GET_PID (inferior_ptid))
+ {
+ pid = -1;
+ save_errno = EINTR;
+ }
+
clear_sigio_trap ();
clear_sigint_trap ();
}
@@ -1091,6 +1099,17 @@ lin_lwp_wait (ptid_t ptid, struct target
gdb_assert (pid == -1 || lwpid == pid);
lp = find_lwp_pid (pid_to_ptid (lwpid));
+
+ /* Make sure we don't report an event for the exit of an LWP not in
+ our list, i.e. not part of the current process. This can happen
+ if we detach from a program we original forked and then it
+ exits. */
+ if (! WIFSTOPPED (status) && ! lp)
+ {
+ status = 0;
+ continue;
+ }
+
if (! lp)
{
lp = add_lwp (BUILD_LWP (lwpid, GET_PID (inferior_ptid)));
next reply other threads:[~2002-12-15 21:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-15 13:43 Daniel Jacobowitz [this message]
2003-01-06 23:54 ` Michael Snyder
2003-01-07 0:50 ` Daniel Jacobowitz
2003-01-09 19:16 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021215213952.GA3923@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@gnu.org \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox