From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20652 invoked by alias); 15 Dec 2002 21:10:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20645 invoked from network); 15 Dec 2002 21:10:49 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 15 Dec 2002 21:10:49 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18NhuT-0002QS-00; Sun, 15 Dec 2002 17:10:58 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18Ng2u-0000Ph-00; Sun, 15 Dec 2002 16:11:32 -0500 Date: Sun, 15 Dec 2002 13:38:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Cc: jjohnstn@redhat.com Subject: Recent MI patches broke the testsuite Message-ID: <20021215211132.GA31984@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com, jjohnstn@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.1i X-SW-Source: 2002-12/txt/msg00461.txt.bz2 202-environment-directory ../../../src/gdb/testsuite/gdb.mi 202^done,source-path="/opt/src/binutils/x86-as/gdb/testsuite/../../../src/gdb/testsuite/gdb.mi:$cdir:$cwd" (gdb) FAIL: gdb.mi/mi-basics.exp: environment-directory arg operation 203-environment-directory 203^done,source-path="/opt/src/binutils/x86-as/gdb/testsuite/../../../src/gdb/testsuite/gdb.mi:$cdir:$cwd" (gdb) FAIL: gdb.mi/mi-basics.exp: environment-directory empty-string operation It appears to be this patch: 2002-12-13 Jeff Johnston * mi-cmds.c (-environment-directory) Change to use mi_cmd_env_dir, (-environment-cd): Change to use mi_cmd_env_cd,. (-environment-pwd): Change to use mi_cmd_env_pwd. (-environment-path): Change to use mi_cmd_env_path. * mi-cmds.h (mi_cmd_env_cd, mi_cmd_env_dir): New prototypes. (mi_cmd_env_path, mi_cmd_env_pwd): Ditto. * mi-cmd-env.c: New file. Part of fix for PR gdb/741. * gdbmi.texinfo (environment-cd): Update output and example. (environment-pwd): Ditto. (environment-dir): Update output, description, and examples. (environment-path): Ditto. Not only did it break several tests in gdb.mi/, it also broke the utility function mi_gdb_reinitialize_dir in lib/mi-support.exp. This causes all my testsuite runs to time out. Please don't commit patches like this without testing them. The output which expects "105-^done\r\n" needs to be updated as well as the tests in mi-basics.exp; possibly elsewhere. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer