From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] New function type_code_name.
Date: Sat, 14 Dec 2002 02:32:00 -0000 [thread overview]
Message-ID: <20021214072129.GA26331@nevyn.them.org> (raw)
In-Reply-To: <B87A936F-0D67-11D7-9BDD-00039396EEB8@apple.com>
On Wed, Dec 11, 2002 at 07:21:55PM -0500, Klee Dienes wrote:
> This patch moves the type-printing code from recursive_dump_type() into
> the new function type_code_name(). It's handy when one wants to use
> the type code of a type in debugging or warning/error messages.
>
> 2002-12-11 Klee Dienes <kdienes@apple.com>
>
> * gdbtypes.h (type_code_name): Add prototype.
> * gdbtypes.c (type_code_name): New function. Returns a
> constant string containing the ASCII name of the type code.
> (recursive_dump_type): Use type_code_name.
This is mostly OK. Would you add a comment by the enum for TYPE_CODE_*
mentioning the list in type_code_name ()? Also, the argument to
type_code_name should be an enum type_code, not an int.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2002-12-14 7:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-11 17:41 Klee Dienes
2002-12-12 9:12 ` Richard Earnshaw
2002-12-14 2:32 ` Daniel Jacobowitz [this message]
2003-01-03 21:11 ` Elena Zannoni
2003-01-03 21:35 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021214072129.GA26331@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox