From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20145 invoked by alias); 11 Dec 2002 20:07:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20136 invoked from network); 11 Dec 2002 20:07:17 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 11 Dec 2002 20:07:17 -0000 Received: by localhost.redhat.com (Postfix, from userid 1008) id A87E13C17; Wed, 11 Dec 2002 15:07:06 -0500 (EST) Subject: Re: [RFA] dwarf2read.c: complain() -> complaint() In-Reply-To: "from Jim Blandy at Dec 11, 2002 01:00:19 pm" To: Jim Blandy Date: Wed, 11 Dec 2002 12:23:00 -0000 Cc: Andrew Cagney , gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Message-Id: <20021211200706.A87E13C17@localhost.redhat.com> From: ac131313@redhat.com (Andrew Cagney) X-SW-Source: 2002-12/txt/msg00364.txt.bz2 > It looks fine to me. > > I was uncomfortable with the idea of having to create wrapper > functions at first --- the idea being that each occurrence of a > complaint string is its own independent complaint --- but it seems > like it'll do the right thing by default more often than making people > create complaint structures. So I'll go with that. I'm not sure what you mean. The wrapper function was only suggested when an identical complaint is being reported from more than one place in the file. See "complaints.h". Andrew