Re: [PATCH] Get rid of DEPRECATED_PC_IN_CALL_DUMMY in i386-tdep.c

Andrew Cagney
2002-12-13T00:06:31Z

> I was looking at the DEPRECATED_PC_IN_CALL_DUMMY use in arm-tdep.c last
> night and I came to the conclusion that I hadn't a clue what I was
> supposed to do to remove it. Is all the code dead? Does it all need
> translating into pc_in_dummy_frame? etc, etc.
>
> Could I suggest that when we deprecate a call some documentation is added
> *somewhere* saying what sort of things (I accept that it might not be a
> trivial substitution) should be used to replace existing deprecated code.
> One possible place would be in gdbarch.sh, though that's constrained a
> bit. doc/deprecated.texinfo?

I try to leave a comment with the doco but keep missing them :-(

> something of the form
>
> ->> DEPRECATED_PC_IN_CALL_DUMMY: Replace with calls to XXX or YYY as
> appropriate using the new ZZZ methods for doing wibble.
>
> This would then be a key for things to look up in the manual (the new
> methods are documented, right?) to understand how it's all supposed to
> work.

Things to do during my summer holidays is write said doco (that and the
register cache).

As for deprecated_pc_in_call_dummy. It should be dead, not needed,
redundant, superfulious[sp], irrelevant, gone to meet its creator,
ceased to be, .... the only time GDB should call the tdep code is on a
normal frame.

However, because I've not committed the changes that re-order frame
initialization to use the sequence:

frame_pc_unwind()
frame_id_unwind()
create frame

The arm may in some way still depend on that macro. If it does I'd like
to know.

Andrew