Re: [PATCH] Get rid of DEPRECATED_PC_IN_CALL_DUMMY in i386-tdep.c

Richard Earnshaw
2002-12-12T10:48:16Z

I was looking at the DEPRECATED_PC_IN_CALL_DUMMY use in arm-tdep.c last
night and I came to the conclusion that I hadn't a clue what I was
supposed to do to remove it. Is all the code dead? Does it all need
translating into pc_in_dummy_frame? etc, etc.

Could I suggest that when we deprecate a call some documentation is added
*somewhere* saying what sort of things (I accept that it might not be a
trivial substitution) should be used to replace existing deprecated code.
One possible place would be in gdbarch.sh, though that's constrained a
bit. doc/deprecated.texinfo?

something of the form

->> DEPRECATED_PC_IN_CALL_DUMMY: Replace with calls to XXX or YYY as
appropriate using the new ZZZ methods for doing wibble.

This would then be a key for things to look up in the manual (the new
methods are documented, right?) to understand how it's all supposed to
work.

R.