Re: [PATCH] Get rid of DEPRECATED_PC_IN_CALL_DUMMY in i386-tdep.c

Andrew Cagney
2002-12-11T14:56:09Z

Mark,

> @@ -566,7 +567,7 @@ i386_sigtramp_saved_sp (struct frame_inf
> static CORE_ADDR
> i386_frame_saved_pc (struct frame_info *frame)
> {
> - if (DEPRECATED_PC_IN_CALL_DUMMY (frame->pc, 0, 0))
> + if (pc_in_dummy_frame (frame->pc))
> {
> ULONGEST pc;
>

What happens if you simply delete the above? This function should now
only be called on non-dummy frames.

> @@ -509,7 +510,7 @@ i386_frameless_signal_p (struct frame_in
> static CORE_ADDR
> i386_frame_chain (struct frame_info *frame)
> {
> - if (DEPRECATED_PC_IN_CALL_DUMMY (frame->pc, 0, 0))
> + if (pc_in_dummy_frame (frame->pc))
> return frame->frame;
>
> if (get_frame_type (frame) == SIGTRAMP_FRAME

This test hasn't quite been eliminated. I need to add
frame_id_unwind() to the frame object.

Andrew