From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15684 invoked by alias); 9 Dec 2002 04:42:42 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15676 invoked from network); 9 Dec 2002 04:42:42 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 9 Dec 2002 04:42:42 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18LHd0-0001tt-00; Mon, 09 Dec 2002 00:42:54 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18LFlG-0000YH-00; Sun, 08 Dec 2002 23:43:18 -0500 Date: Sun, 08 Dec 2002 22:07:00 -0000 From: Daniel Jacobowitz To: Elena Zannoni Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] fix -Werrors from new readline Message-ID: <20021209044318.GA1957@nevyn.them.org> Mail-Followup-To: Elena Zannoni , gdb-patches@sources.redhat.com References: <15859.59924.42114.329528@localhost.redhat.com> <15859.61596.274561.455522@localhost.redhat.com> <20021209013830.GA27320@nevyn.them.org> <15860.7482.156282.685877@localhost.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15860.7482.156282.685877@localhost.redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-12/txt/msg00278.txt.bz2 On Sun, Dec 08, 2002 at 11:34:02PM -0500, Elena Zannoni wrote: > Daniel Jacobowitz writes: > > On Sun, Dec 08, 2002 at 08:23:40PM -0500, Elena Zannoni wrote: > > > > > > > > > And the makefile. > > > > > > 2002-12-08 Elena Zannoni > > > > > > * Makefile.in (readline_h): Define. > > > (completer.o): Depend on readline_h. > > > (corelow.o): Ditto. > > > (event-top.o): Ditto. > > > (exec.o): Ditto. > > > (solib.o): Ditto. > > > (source.o): Ditto. > > > (symfile.o): Ditto. > > > (symmisc.o): Ditto. > > > (top.o): Ditto. > > > (tracepoint.o): Ditto. > > > (utils.o): Ditto. > > > (cli-dump.o): Ditto. > > > (tui-hooks.o): Ditto. > > > (tuiWin.o): Ditto. > > > > > +readline_h = $(READLINE_SRC)/readline.h > > > > Erk, is this necessary? It comes from the combined source tree, but > > it's basically a 'system' header. I compile using the system readline > > instead of the included one; this is just another thing which would get > > in the way of doing that. > > > > Hmm, but what happens if the system readline and gdb's readline get > out of sync again? BTW, there was a readline_h already used in some > tui files, but it wasn't defined. I cry? :) I've been maintaining patches to use the system readline. You've just integrated pretty much all of them. > Rereading your sentence... you are trying to get rid of src/readline? Certainly not. What I want to do is add a --with-system-readline, analagous to GCC's --with-system-zlib; it's pretty straightforward to do as long as the interface stays "reasonably" stable. Upon rethinking it, I doubt the $(readline_h) dependency will be a problem. Someday I would like to make GDB use BFD's make dep-am mechanism... -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer