From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28578 invoked by alias); 4 Dec 2002 03:55:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28570 invoked from network); 4 Dec 2002 03:55:23 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 4 Dec 2002 03:55:23 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18JSVN-0006gs-00; Tue, 03 Dec 2002 23:55:29 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18JQdK-0005ED-00; Tue, 03 Dec 2002 22:55:34 -0500 Date: Tue, 03 Dec 2002 19:55:00 -0000 From: Daniel Jacobowitz To: Pierre Muller Cc: Andreas Schwab , gdb-patches@sources.redhat.com Subject: Re: [RFC] Correct gdbserver register packets Message-ID: <20021204035534.GA16186@nevyn.them.org> Mail-Followup-To: Pierre Muller , Andreas Schwab , gdb-patches@sources.redhat.com References: <5.0.2.1.2.20021126162728.02a31e50@ics.u-strasbg.fr> <20021202011500.GA19215@nevyn.them.org> <5.0.2.1.2.20021203092802.034b2c20@ics.u-strasbg.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5.0.2.1.2.20021203092802.034b2c20@ics.u-strasbg.fr> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-12/txt/msg00105.txt.bz2 On Tue, Dec 03, 2002 at 09:29:14AM +0100, Pierre Muller wrote: > At 06:21 03/12/2002, Daniel Jacobowitz wrote: > >On Mon, Dec 02, 2002 at 11:44:31AM +0100, Andreas Schwab wrote: > >> Daniel Jacobowitz writes: > >> > >> |> Or else Andreas's patch to decrease the number of registers. Hmm, > >> |> probably doing it Andreas's way is better. I'll take care of this in > >> |> the morning. > >> > >> My way of fixing it is not complete, I get "Wrong sized register packet" > >> messages from gdbserver. > > > >There's a much easier solution: change the 31 to 29, and remove the > >extra two registers from regformats/. I'm not familiar with any m68k > >stubs; do you know of any others that do or do not include the extra > >two registers, which GDB no longer seems to know anything about? Or > >are they just bogus? > > > config/m68k/tm-sun3.h > seems to use 31 registers including the two not known by > other m68k targets... > But I don't known the state of that target... "very old". It seems that the base for all/most m68k targets is to have 29 registers. As a result, I think this patch is the way to go. Could you two give it a try? -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer 2002-11-30 Andreas Schwab * linux-m68k-low.c (m68k_num_regs): Define to 29 instead of 31. 2002-12-03 Daniel Jacobowitz * regformats/reg-m68k.dat: Remove fpcode and fpflags. Index: gdbserver/linux-m68k-low.c =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/linux-m68k-low.c,v retrieving revision 1.3 diff -u -p -r1.3 linux-m68k-low.c --- gdbserver/linux-m68k-low.c 9 Apr 2002 22:44:43 -0000 1.3 +++ gdbserver/linux-m68k-low.c 4 Dec 2002 03:43:52 -0000 @@ -26,7 +26,7 @@ #include #endif -#define m68k_num_regs 31 +#define m68k_num_regs 29 /* This table must line up with REGISTER_NAMES in tm-m68k.h */ static int m68k_regmap[] = Index: regformats/reg-m68k.dat =================================================================== RCS file: /cvs/src/src/gdb/regformats/reg-m68k.dat,v retrieving revision 1.1 diff -u -p -r1.1 reg-m68k.dat --- regformats/reg-m68k.dat 1 Feb 2002 22:05:28 -0000 1.1 +++ regformats/reg-m68k.dat 4 Dec 2002 03:43:52 -0000 @@ -31,5 +31,3 @@ expedite:sp,fp,pc 32:fpcontrol 32:fpstatus 32:fpiaddr -32:fpcode -32:fpflags