From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16410 invoked by alias); 30 Nov 2002 18:01:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16396 invoked from network); 30 Nov 2002 18:01:08 -0000 Received: from unknown (HELO mail.cs.umass.edu) (128.119.243.168) by sources.redhat.com with SMTP; 30 Nov 2002 18:01:08 -0000 Received: from localhost (IDENT:NEPxvM/h/k/Lx6ZAAu1NZTIDdr73K58D@loki.cs.umass.edu [128.119.243.168]) by mail.cs.umass.edu (8.12.6/8.12.5) with ESMTP id gAUI0VX1020431; Sat, 30 Nov 2002 13:00:31 -0500 Date: Sat, 30 Nov 2002 10:01:00 -0000 Message-Id: <20021130.130027.74732311.kazu@cs.umass.edu> To: dvenkat@noida.hcltech.com Cc: gdb-patches@sources.redhat.com, binutils@sources.redhat.com Subject: Re: PATCH : H8300 Simulator File I/O Implementation From: Kazu Hirata In-Reply-To: References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Checked: This message probably not SPAM X-Spam-Score: -3.4, Required: 5 X-Spam-Tests: IN_REP_TO X-Spam-Report: SPAM: -3.4 hits, 5 required; SPAM: * -3.4 -- Found a In-Reply-To header X-Scanned-By: MIMEDefang 2.26 (www . roaringpenguin . com / mimedefang) X-SW-Source: 2002-11/txt/msg00764.txt.bz2 Hi Venky, You might want to send your patch to newlib@sources.redhat.com as well, possibly after separating the patch for individual projects (binutils, newlib, and gdb-patches)!? ! /* And a jsr to these locations are turned into magic traps. */ if (dst->opcode == O (O_JSR, SB)) { ! if (dst->src.literal == 0xc5) This may be up to your preference, but what about "switch (dst->src.literal)"? ! /* Setting filename_ptr to first argument of open */ ! filename_ptr = cpu.regs[0]; I think the GNU coding standard prefers a complete sentence (well, except the subject) ending with a period and two spaces like /* Set filename_ptr to the first argument of open. */ ! /* Allocating space for the filename */ ! filename = (char *)malloc(sizeof(char) * len); Do you free this filename somewhere? Thanks, Kazu Hirata