From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1252 invoked by alias); 29 Nov 2002 00:36:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1244 invoked from network); 29 Nov 2002 00:36:45 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 29 Nov 2002 00:36:45 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id B1CB0D2D29; Thu, 28 Nov 2002 16:36:45 -0800 (PST) Date: Thu, 28 Nov 2002 16:36:00 -0000 From: Joel Brobecker To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/5.3] AiX: enable thread support only if libpthdebug is recent enough Message-ID: <20021129003645.GO1259@gnat.com> References: <20021128051647.GX1259@gnat.com> <20021128051817.GY1259@gnat.com> <3DE65F3B.9060104@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Qf1oXS95uex85X0R" Content-Disposition: inline In-Reply-To: <3DE65F3B.9060104@redhat.com> User-Agent: Mutt/1.4i X-SW-Source: 2002-11/txt/msg00733.txt.bz2 --Qf1oXS95uex85X0R Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 1075 > >2002-11-27 J. Brobecker > > > > * configure.in: Check that the pthdebug library is recent enough > > before enable thread support on native AiX. > > * configure: Regenerate. > > > > * config/powerpc/aix432.mh (NATDEPFILES): Remove aix-thread.o > > from the list of object files as it is now appended by configure > > if thread support is enabled. > > (NAT_CLIBS): Removed as -lpthdebug is also appended by configure > > if thread support is enabled. > > Looks `safe' - can only hurts AIX - so yes, ok for both 5.3 and mainline. > Can you just, while you're at it, update the comment at the start of the > containing switch so that it beter reflects current reality. The patch that I committed to the 5.3 branch is actually slightly differrent. I just ommitted the comments in the solaris branch of the case statement, just to play it safe. And I also tested the changes by reconfiguring on Solaris, and I verifed that the Makefile in gdb was identical before and after the change. -- Joel --Qf1oXS95uex85X0R Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="aix-thread-branch.diff" Content-length: 3201 Index: configure.in =================================================================== RCS file: /cvs/src/src/gdb/configure.in,v retrieving revision 1.90.6.1 diff -c -3 -p -r1.90.6.1 configure.in *** configure.in 26 Nov 2002 01:32:21 -0000 1.90.6.1 --- configure.in 29 Nov 2002 00:23:34 -0000 *************** aix*) *** 532,543 **** ;; esac - dnl See if thread_db library is around for Solaris thread debugging. Note that - dnl we must explicitly test for version 1 of the library because version 0 - dnl (present on Solaris 2.4 or earlier) doesn't have the same API. ! dnl Note that we only want this if we are both native (host == target), and ! dnl not doing a canadian cross build (build == host). if test ${build} = ${host} -a ${host} = ${target} ; then case ${host_os} in --- 532,543 ---- ;; esac ! dnl For certain native configurations, we need to check whether thread ! dnl support can be built in or not. ! dnl ! dnl Note that we only want this if we are both native (host == target), ! dnl and not doing a canadian cross build (build == host). if test ${build} = ${host} -a ${host} = ${target} ; then case ${host_os} in *************** if test ${build} = ${host} -a ${host} = *** 594,599 **** --- 594,615 ---- fi else AC_MSG_RESULT(no) + fi + ;; + aix*) + AC_MSG_CHECKING(for AiX thread debugging library) + AC_CACHE_VAL(gdb_cv_have_aix_thread_debug, + [AC_TRY_COMPILE([#include ], + [#ifndef PTHDB_VERSION_3 + #error + #endif], + gdb_cv_have_aix_thread_debug=yes, + gdb_cv_have_aix_thread_debug=no)]) + AC_MSG_RESULT($gdb_cv_have_aix_thread_debug) + if test $gdb_cv_have_aix_thread_debug = yes; then + CONFIG_SRCS="${CONFIG_SRCS} aix-thread.c" + CONFIG_LIB_OBS="${CONFIG_LIB_OBS} aix-thread.o" + CONFIG_LDFLAGS="${CONFIG_LDFLAGS} -lpthdebug" fi ;; esac Index: config/powerpc/aix432.mh =================================================================== RCS file: /cvs/src/src/gdb/config/powerpc/aix432.mh,v retrieving revision 1.1 diff -c -3 -p -r1.1 aix432.mh *** config/powerpc/aix432.mh 30 Jul 2002 19:59:06 -0000 1.1 --- config/powerpc/aix432.mh 29 Nov 2002 00:23:34 -0000 *************** *** 3,9 **** XM_FILE= xm-aix.h NAT_FILE= nm-aix.h ! NATDEPFILES= aix-thread.o fork-child.o infptrace.o inftarg.o corelow.o \ rs6000-nat.o xcoffread.o xcoffsolib.o # When compiled with cc, for debugging, this argument should be passed. --- 3,9 ---- XM_FILE= xm-aix.h NAT_FILE= nm-aix.h ! NATDEPFILES= fork-child.o infptrace.o inftarg.o corelow.o \ rs6000-nat.o xcoffread.o xcoffsolib.o # When compiled with cc, for debugging, this argument should be passed. *************** NATDEPFILES= aix-thread.o fork-child.o i *** 15,19 **** # This switch may be needed for some vendor compilers. # MH_LDFLAGS = -Wl,-bbigtoc - # pthread debugging support - NAT_CLIBS = -lpthdebug --- 15,17 ---- --Qf1oXS95uex85X0R--