From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1873 invoked by alias); 14 Nov 2002 19:52:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1866 invoked from network); 14 Nov 2002 19:52:11 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 14 Nov 2002 19:52:11 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18CQ1y-00084I-00; Thu, 14 Nov 2002 13:52:02 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18CQ3E-0000sY-00; Thu, 14 Nov 2002 14:53:20 -0500 Date: Thu, 14 Nov 2002 11:52:00 -0000 From: Daniel Jacobowitz To: Pierre Muller Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] Display exact entered expression for watchpoints Message-ID: <20021114195320.GA3094@nevyn.them.org> Mail-Followup-To: Pierre Muller , gdb-patches@sources.redhat.com References: <5.0.2.1.2.20021114112441.032c9fb0@ics.u-strasbg.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5.0.2.1.2.20021114112441.032c9fb0@ics.u-strasbg.fr> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-11/txt/msg00413.txt.bz2 On Thu, Nov 14, 2002 at 12:00:18PM +0100, Pierre Muller wrote: > When I watch a memory location, > I almost always use hexadecimal notation. > > For instance lets say that I want to watch > the memory containing the value of gdb_stderr > On my linux box > (top-gdb)p &gdb_stderr > returns > $1 = (struct ui_file **) 0x823b5cc > (ok, here I could simply use 'watch gdb_stderr, > but in some other cases like dynamically allocated memory I can't). > if I enter > (top-gdb) watch *0x823b5cc > Hardware watchpoint 3: *136558028 > (top-gdb) inf b > Num Type Disp Enb Address What > 1 breakpoint keep y 0x080f0d79 in internal_error > at ../../src/origdb/utils.c:810 > 2 breakpoint keep y 0x080783eb in info_command > at ../../src/origdb/cli/cli-cmds.c:202 > silent > return > 3 hw watchpoint keep y *136558028 > (top-gdb) > > > After my patch, I get > (top-gdb) watch *0x823b5cc > Hardware watchpoint 3: *0x823b5cc > (top-gdb) inf b > Num Type Disp Enb Address What > 1 breakpoint keep y 0x080f0d79 in internal_error > at ../../src/origdb/utils.c:810 > 2 breakpoint keep y 0x080783eb in info_command > at ../../src/origdb/cli/cli-cmds.c:202 > silent > return > 3 hw watchpoint keep y *0x823b5cc > > > I really prefer the later, I like this behavior a lot better too; I see the number and get hopelessly confused as to what I'm watching :) Michael, Jim, do you think this will cause any problems? Watch doesn't take an implicit argument the way that break does, so a string should always be available. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer