From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22389 invoked by alias); 12 Nov 2002 20:38:54 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22381 invoked from network); 12 Nov 2002 20:38:52 -0000 Received: from unknown (HELO darkstar.welcomehome.org) (192.203.188.2) by sources.redhat.com with SMTP; 12 Nov 2002 20:38:52 -0000 Received: (from rob@localhost) by darkstar.welcomehome.org (8.11.6/8.11.6) id gACKZWr16315; Tue, 12 Nov 2002 13:35:32 -0700 Date: Tue, 12 Nov 2002 12:38:00 -0000 From: Rob Savoye To: Hans-Peter Nilsson Cc: bug-dejagnu@gnu.org, gdb-patches@sources.redhat.com Subject: Re: [Bug-dejagnu] [RFA:] DejaGNU patch: Change -I to -isystem for testsuite. Message-ID: <20021112133532.E29599@welcomehome.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from Hans-Peter Nilsson on Sat, Oct 26, 2002 at 11:33:41PM -0400 X-SW-Source: 2002-11/txt/msg00354.txt.bz2 On Sat, Oct 26, 2002 at 11:33:41PM -0400, Hans-Peter Nilsson wrote: > system_header", it shouldn't be needed; it'd be better if gcc > treated it as a system header while running the test-suite. > Done by changing -I to -isystem for include directives for the > test-suite. The -isystem option has been there since at least > gcc-2.7.2 so it should be safe for all uses. This patch is Makes sense. > BTW, does anybody have an idea why gcc/testsuite/site.exp is > completely ineffective? Changing s/-I/-isystem/g in the > site.exp in gcc/Makefile.in has no effect; in fact it doesn't > seem to be used at all. I believe the site.exp that is actually read in is from the gcc directory, not the gcc/testsuite one. > Ok to commit to sources.redhat.com/dejagnu? Looks ok to me. I'll check this into savannah after I merge in the patch. - rob -