From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Received: (qmail 26089 invoked from network); 11 Nov 2002 22:55:28 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 11 Nov 2002 22:55:28 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18BPKs-0000HJ-00; Mon, 11 Nov 2002 18:55:22 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18BNTY-0007Xp-00; Mon, 11 Nov 2002 17:56:12 -0500 Date: Mon, 11 Nov 2002 17:15:00 -0000 From: Daniel Jacobowitz To: Klee Dienes Cc: David Carlton , Jim Blandy , Fernando Nasser , Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [rfa] linespec.c, part 3 Message-ID: <20021111225612.GA28829@nevyn.them.org> Mail-Followup-To: Klee Dienes , David Carlton , Jim Blandy , Fernando Nasser , Elena Zannoni , gdb-patches@sources.redhat.com References: <35E8C110-F5C5-11D6-AA35-00039396EEB8@apple.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <35E8C110-F5C5-11D6-AA35-00039396EEB8@apple.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-11/txt/msg00329.txt.bz2 On Mon, Nov 11, 2002 at 05:30:41PM -0500, Klee Dienes wrote: > I'm not sure if you want to deal with this now, or if you'd rather I > wait until you're done with merging your changes, but I figured I'd > mention it now while you were looking at set_flags stuff: > > The linespec.c changes you posted looked so cool, we couldn't resist > using them. So rather than try to deal with the merge conflicts from > the upcoming stream of linespec.c patches, we decided to re-add our > Objective-C support to the linespec.c from your branch and use that as > our linespec.c. > > One issue that came up was that the part of our code that decodes an > Objective-C function needs to have the if-clause removed from the > breakpoint expression (since Objective-C functions can contain spaces). > We did this by extending set_flags to pass back a pointer to the > if-clause, if there was one, and by splitting decode_line_1 into two > functions, one of which sets the defaults, calls set_flags, strips off > the if-clause and calls decode_line_2, which does the actual parsing. Dare I ask what you did with the existing decode_line_2, also in that file? Other than that, it looks reasonable... -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer