From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23219 invoked by alias); 11 Nov 2002 04:22:23 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23212 invoked from network); 11 Nov 2002 04:22:22 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 11 Nov 2002 04:22:22 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18B7y2-0007BQ-00; Mon, 11 Nov 2002 00:22:38 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18B66g-0001yh-00; Sun, 10 Nov 2002 23:23:26 -0500 Date: Sun, 10 Nov 2002 20:22:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH: Remove unnecessary zero-initializations Message-ID: <20021111042326.GA7554@nevyn.them.org> Mail-Followup-To: Andrew Cagney , gdb-patches@sources.redhat.com References: <20021111001910.GA17944@nevyn.them.org> <3DCF2D6E.2030407@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3DCF2D6E.2030407@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-11/txt/msg00301.txt.bz2 On Sun, Nov 10, 2002 at 11:09:18PM -0500, Andrew Cagney wrote: > >Currently, thirteen files which provide a target_ops explicitly initialize > >members they don't support to NULL. I plan to delete a number of these > >methods, and rather than making sure I got all the necessary target files > >each time I just wanted to delete the unnecessary lines up-front. All of > >these are called-once functions initializing a statically or globally > >declared object; C will guarantee zero-initialization for us. And several > >of the functions explicitly called memset anyway. > > > >Besides, this way grepping for .to_require_attach\ = will only find targets > >which define it to something useful. > > > >I'll commit this tomorrow unless someone sees a problem with it. > > > >Note1: remote-st.c hasn't been compilable in a while; m68*-tandem-* is > >probably a good candidate for the hitlist. From a glance it looks like it > >has been broken since the HP merge added the NULL assignments I'm removing, > >which is about three years now I think. > > > >Note2: The DONT_USE member of struct target_ops can go now. > > The fact that 13 files were doing it should suggest that it was > intentional. Might want to wait a bit longer while someone dregs up the > history. Well, to me the fact that those thirteen files were doing it implies it's a leftover. Look at them; the two win* one are cut-pasted from inftarg.c; the others (except for sol-thread.c) are cut-pasted from remote.c. And neither of those has the zeros. But it doesn't cost me anything to wait, except for slowing down the progress on the fork patches :) I'll give it a few days. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer