From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26820 invoked by alias); 7 Nov 2002 19:43:30 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26810 invoked from network); 7 Nov 2002 19:43:29 -0000 Received: from unknown (HELO mailsrv.otenet.gr) (195.170.0.5) by sources.redhat.com with SMTP; 7 Nov 2002 19:43:29 -0000 Received: from neutrino.particles.org (athe530-h028.otenet.gr [212.205.217.28]) by mailsrv.otenet.gr (8.12.6/8.12.6) with ESMTP id gA7JhMe7009538; Thu, 7 Nov 2002 21:43:22 +0200 (EET) Received: (from anteater@localhost) by neutrino.particles.org (8.11.6/8.11.6) id gA7L3L803709; Thu, 7 Nov 2002 23:03:21 +0200 Date: Thu, 07 Nov 2002 11:43:00 -0000 From: Elias Athanasopoulos To: gdb-patches@sources.redhat.com Cc: Daniel Jacobowitz Subject: Re: [PATCH/RFC] faster language identification Message-ID: <20021107230321.F1136@neutrino.particles.org> References: <20021107224622.D1136@neutrino.particles.org> <20021107193409.GA25879@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20021107193409.GA25879@nevyn.them.org>; from drow@mvista.com on Thu, Nov 07, 2002 at 02:34:09PM -0500 X-SW-Source: 2002-11/txt/msg00188.txt.bz2 Hi Daniel, On Thu, Nov 07, 2002 at 02:34:09PM -0500, Daniel Jacobowitz wrote: > Please don't. See: > > /* Set the initial language. > > A better solution would be to record the language in the psymtab when reading > partial symbols, and then use it (if known) to set the language. This would > be a win for formats that encode the language in an easily discoverable place, > such as DWARF. For stabs, we can jump through hoops looking for specially > named symbols or try to intuit the language from the specific type of stabs > we find, but we can't do that until later when we read in full symbols. > FIXME. */ > > static void > set_initial_language (void) > > Either that or there should be a psymtab_language() method somewhere. Actually, this is what the patch does. :-) It sets the language according to the information recorded in the psymtab (_if_ it is recorded, as it does with DWARF). Elias