From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29672 invoked by alias); 7 Nov 2002 19:47:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29618 invoked from network); 7 Nov 2002 19:47:41 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 7 Nov 2002 19:47:41 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 189uVJ-0001lC-00; Thu, 07 Nov 2002 15:47:58 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 189sdq-0006x9-00; Thu, 07 Nov 2002 14:48:38 -0500 Date: Thu, 07 Nov 2002 11:47:00 -0000 From: Daniel Jacobowitz To: Elias Athanasopoulos Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH/RFC] faster language identification Message-ID: <20021107194838.GA26711@nevyn.them.org> Mail-Followup-To: Elias Athanasopoulos , gdb-patches@sources.redhat.com References: <20021107224622.D1136@neutrino.particles.org> <20021107193409.GA25879@nevyn.them.org> <20021107230321.F1136@neutrino.particles.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021107230321.F1136@neutrino.particles.org> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-11/txt/msg00189.txt.bz2 On Thu, Nov 07, 2002 at 11:03:21PM +0200, Elias Athanasopoulos wrote: > Hi Daniel, > > On Thu, Nov 07, 2002 at 02:34:09PM -0500, Daniel Jacobowitz wrote: > > Please don't. See: > > > > /* Set the initial language. > > > > A better solution would be to record the language in the psymtab when reading > > partial symbols, and then use it (if known) to set the language. This would > > be a win for formats that encode the language in an easily discoverable place, > > such as DWARF. For stabs, we can jump through hoops looking for specially > > named symbols or try to intuit the language from the specific type of stabs > > we find, but we can't do that until later when we read in full symbols. > > FIXME. */ > > > > static void > > set_initial_language (void) > > > > Either that or there should be a psymtab_language() method somewhere. > > Actually, this is what the patch does. :-) It sets the language according > to the information recorded in the psymtab (_if_ it is recorded, as it does with > DWARF). No, the patch converts the psymtab to a symtab and uses the language in the symtab. That's what I want you NOT to do. psymtab_to_symtab is expensive! -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer