From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20185 invoked by alias); 7 Nov 2002 19:33:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20176 invoked from network); 7 Nov 2002 19:33:18 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 7 Nov 2002 19:33:18 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 189uHH-0001jP-00; Thu, 07 Nov 2002 15:33:28 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 189sPp-0006mj-00; Thu, 07 Nov 2002 14:34:09 -0500 Date: Thu, 07 Nov 2002 11:33:00 -0000 From: Daniel Jacobowitz To: Elias Athanasopoulos Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH/RFC] faster language identification Message-ID: <20021107193409.GA25879@nevyn.them.org> Mail-Followup-To: Elias Athanasopoulos , gdb-patches@sources.redhat.com References: <20021107224622.D1136@neutrino.particles.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021107224622.D1136@neutrino.particles.org> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-11/txt/msg00186.txt.bz2 On Thu, Nov 07, 2002 at 10:46:22PM +0200, Elias Athanasopoulos wrote: > Hi all, > > DWARFx encodes the language. In such a case, I think it is more > reliable to get the language from the object, instead of looking at the > source files' extensions. > > Comments? Please don't. See: /* Set the initial language. A better solution would be to record the language in the psymtab when reading partial symbols, and then use it (if known) to set the language. This would be a win for formats that encode the language in an easily discoverable place, such as DWARF. For stabs, we can jump through hoops looking for specially named symbols or try to intuit the language from the specific type of stabs we find, but we can't do that until later when we read in full symbols. FIXME. */ static void set_initial_language (void) Either that or there should be a psymtab_language() method somewhere. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer