From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15823 invoked by alias); 5 Nov 2002 21:43:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15798 invoked from network); 5 Nov 2002 21:43:20 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 5 Nov 2002 21:43:20 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 189CPF-0007pp-00; Tue, 05 Nov 2002 16:42:45 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 189BUc-0004oH-00; Tue, 05 Nov 2002 16:44:14 -0500 Date: Tue, 05 Nov 2002 13:43:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com, fnasser@redhat.com Subject: Re: [RFA] Use vfork in shell_escape Message-ID: <20021105214414.GB17994@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com, fnasser@redhat.com References: <20021022015205.GA22323@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021022015205.GA22323@nevyn.them.org> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-11/txt/msg00063.txt.bz2 On Mon, Oct 21, 2002 at 09:52:05PM -0400, Daniel Jacobowitz wrote: > This patch is pretty obvious. I couldn't figure out why my machine was > running out of memory; forking GDB to run an 'ls' during the maint.exp tests > can be a bit heavy, since it may have all of glibc's debug info loaded. > This patch seems logical to me... OK to commit? Updated as suggested, to use gdb_vfork.h. Fernando, is this OK? -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer 2002-11-05 Daniel Jacobowitz * Makefile.in (cli-cmds.o): Add $(gdb_vfork_h). * cli/cli-cmds.c: Include "gdb_vfork.h". (shell_escape): Use vfork. Index: Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/Makefile.in,v retrieving revision 1.274 diff -u -p -r1.274 Makefile.in --- Makefile.in 2 Nov 2002 15:13:34 -0000 1.274 +++ Makefile.in 5 Nov 2002 21:40:52 -0000 @@ -2311,7 +2311,7 @@ cli-cmds.o: $(srcdir)/cli/cli-cmds.c $(d $(gdb_wait_h) $(gdb_regex_h) $(gdb_string_h) $(filenames_h) \ $(ui_out_h) $(top_h) $(cli_decode_h) $(cli_script_h) \ $(cli_setshow_h) $(cli_cmds_h) $(source_h) $(linespec_h) \ - $(expression_h) $(language_h) $(objfiles_h) + $(expression_h) $(language_h) $(objfiles_h) $(gdb_vfork_h) $(CC) -c $(INTERNAL_CFLAGS) $(srcdir)/cli/cli-cmds.c cli-decode.o: $(srcdir)/cli/cli-decode.c $(defs_h) $(symtab_h) \ $(gdb_regex_h) $(gdb_string_h) $(ui_out_h) $(cli_cmds_h) \ Index: cli/cli-cmds.c =================================================================== RCS file: /cvs/src/src/gdb/cli/cli-cmds.c,v retrieving revision 1.22 diff -u -p -r1.22 cli-cmds.c --- cli/cli-cmds.c 22 Sep 2002 22:18:41 -0000 1.22 +++ cli/cli-cmds.c 5 Nov 2002 21:40:53 -0000 @@ -25,6 +25,7 @@ #include "gdb_wait.h" /* For shell escape implementation */ #include "gdb_regex.h" /* Used by apropos_command */ #include "gdb_string.h" +#include "gdb_vfork.h" #include "linespec.h" #include "expression.h" #include "language.h" @@ -517,7 +518,7 @@ shell_escape (char *arg, int from_tty) else p++; /* Get past '/' */ - if ((pid = fork ()) == 0) + if ((pid = vfork ()) == 0) { if (!arg) execl (user_shell, p, 0);