From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9580 invoked by alias); 30 Oct 2002 14:10:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9495 invoked from network); 30 Oct 2002 14:10:20 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 30 Oct 2002 14:10:20 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 186uTY-0007m4-00; Wed, 30 Oct 2002 09:09:45 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 186tYb-0005Sp-00; Wed, 30 Oct 2002 09:10:53 -0500 Date: Wed, 30 Oct 2002 06:10:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/Semi-obvious/5.3?] Fix compilation error in hppa-tdep.c Message-ID: <20021030141053.GA20785@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sources.redhat.com References: <20021030080837.GY903@gnat.com> <20021030082803.GA903@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021030082803.GA903@gnat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-10/txt/msg00587.txt.bz2 On Wed, Oct 30, 2002 at 12:28:03AM -0800, Joel Brobecker wrote: > > 2002-10-30 Joel Brobecker > > > > * hppa-tdep.c (find_function_in_inferior): Fix the declaration > > that caused a compilation error on HP/UX. > > (low_text_segment_addres): Fix a compilation warning. > > Actually, I am replying to myself: the fix to find_function_in_inferior > works, but is pretty stupid. Better to remove the extern altogether, > since we get the definition directly from value.h (which caused the > compilation error in the first place). > > Sorry about that, I should not be working that late I suppose. > > Here is a new patch, with a new ChangeLog: > > 2002-10-30 Joel Brobecker > > * hppa-tdep.c (find_function_in_inferior): Remove this extern, > as this is already provided by value.h, and was actually causing > a compilation error due to a conflict in parameter type declaration > due to a missing const keyword. > (low_text_segment_addres): Fix a compilation warning. > > It looks like the 5.3 branch has the same problem, so I'll fix it too > when I get approval for this patch. Your patch is correct (and that's a serious warning, too... there was an actual bug there). With two sets of eyes this is OK to commit, since HP/UX is currently marked as an OBSOLETE candidate. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer