From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10792 invoked by alias); 30 Oct 2002 08:26:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10693 invoked from network); 30 Oct 2002 08:26:13 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 30 Oct 2002 08:26:13 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id D02ABD2CC7; Wed, 30 Oct 2002 00:28:03 -0800 (PST) Date: Wed, 30 Oct 2002 00:26:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: Re: [RFA/Semi-obvious/5.3?] Fix compilation error in hppa-tdep.c Message-ID: <20021030082803.GA903@gnat.com> References: <20021030080837.GY903@gnat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="SkvwRMAIpAhPCcCJ" Content-Disposition: inline In-Reply-To: <20021030080837.GY903@gnat.com> User-Agent: Mutt/1.4i X-SW-Source: 2002-10/txt/msg00585.txt.bz2 --SkvwRMAIpAhPCcCJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 1099 > 2002-10-30 Joel Brobecker > > * hppa-tdep.c (find_function_in_inferior): Fix the declaration > that caused a compilation error on HP/UX. > (low_text_segment_addres): Fix a compilation warning. Actually, I am replying to myself: the fix to find_function_in_inferior works, but is pretty stupid. Better to remove the extern altogether, since we get the definition directly from value.h (which caused the compilation error in the first place). Sorry about that, I should not be working that late I suppose. Here is a new patch, with a new ChangeLog: 2002-10-30 Joel Brobecker * hppa-tdep.c (find_function_in_inferior): Remove this extern, as this is already provided by value.h, and was actually causing a compilation error due to a conflict in parameter type declaration due to a missing const keyword. (low_text_segment_addres): Fix a compilation warning. It looks like the 5.3 branch has the same problem, so I'll fix it too when I get approval for this patch. Thanks, -- Joel --SkvwRMAIpAhPCcCJ Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="hppa-tdep.c.diff" Content-length: 1386 Index: hppa-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/hppa-tdep.c,v retrieving revision 1.28 diff -c -3 -p -r1.28 hppa-tdep.c *** hppa-tdep.c 24 Oct 2002 21:02:53 -0000 1.28 --- hppa-tdep.c 30 Oct 2002 08:24:34 -0000 *************** extern int hp_som_som_object_present; *** 149,157 **** /* In breakpoint.c */ extern int exception_catchpoints_are_fragile; - /* This is defined in valops.c. */ - extern struct value *find_function_in_inferior (char *); - /* Should call_function allocate stack space for a struct return? */ int hppa_use_struct_convention (int gcc_p, struct type *type) --- 149,154 ---- *************** static CORE_ADDR low_text_segment_addres *** 300,306 **** static void record_text_segment_lowaddr (bfd *abfd, asection *section, void *ignored) { ! if ((section->flags & (SEC_ALLOC | SEC_LOAD | SEC_READONLY) == (SEC_ALLOC | SEC_LOAD | SEC_READONLY)) && section->vma < low_text_segment_address) low_text_segment_address = section->vma; --- 297,303 ---- static void record_text_segment_lowaddr (bfd *abfd, asection *section, void *ignored) { ! if (((section->flags & (SEC_ALLOC | SEC_LOAD | SEC_READONLY)) == (SEC_ALLOC | SEC_LOAD | SEC_READONLY)) && section->vma < low_text_segment_address) low_text_segment_address = section->vma; --SkvwRMAIpAhPCcCJ--